Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy flutter/flutter/docs/engine to flutter/engine/docs as-is (no changes) #53595

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

matanlurey
Copy link
Contributor

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2024
@matanlurey matanlurey merged commit 6ae6827 into flutter:main Jun 26, 2024
27 checks passed
@matanlurey matanlurey deleted the add-docs-stub branch June 26, 2024 20:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 27, 2024
…150888)

flutter/engine@1d5e3cc...a9194f0

2024-06-26 [email protected] Roll Skia from 173ee0af82c9 to 55ada83438cd (3 revisions) (flutter/engine#53596)
2024-06-26 [email protected] Return a null image from ImageExternalTextureGL::CreateEGLImage if an EGL display is not available (flutter/engine#53594)
2024-06-26 [email protected] [Impeller] blur - cropped the downsample pass for backdrop filters (flutter/engine#53562)
2024-06-26 [email protected] Roll Skia from 0a979d9f3606 to 173ee0af82c9 (2 revisions) (flutter/engine#53593)
2024-06-26 [email protected] Remove otherwise unused third_party/web_dependencies. (flutter/engine#53588)
2024-06-26 [email protected] Copy `flutter/flutter/docs/engine` to `flutter/engine/docs` as-is (no changes) (flutter/engine#53595)
2024-06-26 [email protected] Roll Dart SDK from 38bb74f63829 to c01f907d34d8 (5 revisions) (flutter/engine#53585)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jul 8, 2024
…lutter#150888)

flutter/engine@1d5e3cc...a9194f0

2024-06-26 [email protected] Roll Skia from 173ee0af82c9 to 55ada83438cd (3 revisions) (flutter/engine#53596)
2024-06-26 [email protected] Return a null image from ImageExternalTextureGL::CreateEGLImage if an EGL display is not available (flutter/engine#53594)
2024-06-26 [email protected] [Impeller] blur - cropped the downsample pass for backdrop filters (flutter/engine#53562)
2024-06-26 [email protected] Roll Skia from 0a979d9f3606 to 173ee0af82c9 (2 revisions) (flutter/engine#53593)
2024-06-26 [email protected] Remove otherwise unused third_party/web_dependencies. (flutter/engine#53588)
2024-06-26 [email protected] Copy `flutter/flutter/docs/engine` to `flutter/engine/docs` as-is (no changes) (flutter/engine#53595)
2024-06-26 [email protected] Roll Dart SDK from 38bb74f63829 to c01f907d34d8 (5 revisions) (flutter/engine#53585)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
- [Testing Android Changes in the Devicelab on an Emulator](../platforms/android/Testing-Android-Changes-in-the-Devicelab-on-an-Emulator.md)
- [Testing the engine](./testing/Testing-the-engine.md)
- [Testing presubmit Engine PRs with the Flutter framework](Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md)
- [The Engine architecture](../about/The-Engine-architecture.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was left behind in flutter repo, so the link is broken now.

@gmackall gmackall mentioned this pull request Aug 27, 2024
8 tasks
auto-submit bot pushed a commit that referenced this pull request Aug 27, 2024
Fixes some links that were broken as a part of #53595, because it was pointed out on discord

Specifically, replaces `../../` with `https://github.com/flutter/flutter/blob/master/docs/` in the places that `grep` surfaced it.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants