[Impeller] experimental canvas bdf support. #53597
Conversation
|
Gonna run tests with this enabled to see what it does, then opt it back out. |
impeller/aiks/experimental_canvas.cc
Outdated
| subpass_coverage = clip_coverage_stack_.CurrentClipCoverage().value_or( | ||
| save_layer_state_.back().coverage); |
There was a problem hiding this comment.
IIUC from earlier, the plan is to do a Save() instead in cases where this ends up being zero size in order to avoid making a zero size texture/RenderPass?
Then, stuff appended within the "skipped" SaveLayer may still append draws, but they shouldn't be able to draw anything into the parent texture given the zero size scissor.
There was a problem hiding this comment.
This is done now. Also, on partial repaint examples we have fewer composited layers compared to the current entity pass. I'm not sure why the current entity pass skip logic doesn't seem to work at eliding the entire layer when there are backdrops.
Experimental Canvas
Current
|
Fixed the entity pass target flip/allocate calls, so now we're correctly reusing textures. I realized that tracking the required mip count requires more information than we have. When we get a bdf, its the previous render target that needed to be created with mips. |
jonahwilliams
added
the
autosubmit
…151016) flutter/engine@f828363...ad1343c 2024-06-28 [email protected] [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53360) 2024-06-28 [email protected] Reland [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53642) 2024-06-28 [email protected] [Impeller] experimental canvas bdf support. (flutter/engine#53597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#151016) flutter/engine@f828363...ad1343c 2024-06-28 [email protected] [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53360) 2024-06-28 [email protected] Reland [DisplayList] Add support for clipOval to leverage Impeller optimization (flutter/engine#53642) 2024-06-28 [email protected] [Impeller] experimental canvas bdf support. (flutter/engine#53597) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Almost working bdf for experimentcal canvas.
Currently there are some problems with the clip depth, and positioning of the backdrop filter. I think I am not taking the blur transform into account at the very least.
FYI @bdero