[Impeller] desktop: Add missing dispatch for TextFrameDispatcher in embedder view. #55197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
changed the title
|
We've got tests:
Although I'm not so sure rendering Skia text in an image compare test is a good idea since it may break with subtle changes in Skia. We may need to change this to forego the image compare and crash on validation failure instead. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2024
…tcher in embedder view. (flutter/engine#55197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2024
…tcher in embedder view. (flutter/engine#55197)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2024
…tcher in embedder view. (flutter/engine#55197)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 14, 2024
…155201) flutter/engine@4d8d851...c83cc88 2024-09-14 [email protected] Roll Dart SDK from c0f7e399ff4a to de4a3d63671c (1 revision) (flutter/engine#55199) 2024-09-14 [email protected] [Impeller] desktop: Add missing dispatch for TextFrameDispatcher in embedder view. (flutter/engine#55197) 2024-09-14 [email protected] Add xcprivacy privacy manifest to macOS framework (flutter/engine#55078) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#155186.
Trying to wire up an embedder test for macOS w/ Impeller at the moment.
Before:
After:
