Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Switch all fonts to WOFF2 (non-split) #56035

Merged
merged 7 commits into from
Nov 5, 2024

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Oct 22, 2024

Google Fonts serves TTF fonts gzipped. By switching to WOFF2 fonts, we get Brotli compression by design.

Google Font's WOFF2 fonts are 30%+ smaller than their gzipped TTF counterparts (including Roboto).

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 22, 2024
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2024
@auto-submit auto-submit bot merged commit e553cd6 into flutter:main Nov 5, 2024
35 checks passed
@mdebbar mdebbar deleted the woff2_all branch November 5, 2024 21:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 6, 2024
…158218)

flutter/engine@e5e06c9...a3741d6

2024-11-05 [email protected] Increase timeouts for Linux Fuchsia and Linux Web Framework Tests builders (flutter/engine#56387)
2024-11-05 [email protected] iOS: Use standard Obj-C cflags for ios_test_flutter (flutter/engine#56384)
2024-11-05 [email protected] Remove unnecessary method for getting engine switches (command line). (flutter/engine#56265)
2024-11-05 [email protected] Remove FlScrollingViewDelegate (flutter/engine#56270)
2024-11-05 [email protected] fml: delete scoped_nsobject.h,mm (flutter/engine#56382)
2024-11-05 [email protected] Roll Skia from b3be9cb59fe8 to 82175b411c80 (2 revisions) (flutter/engine#56383)
2024-11-05 [email protected] [Impeller] Delete any remaining GL objects during destruction of the ReactorGLES (flutter/engine#56361)
2024-11-05 [email protected] [web] Switch all fonts to WOFF2 (non-split) (flutter/engine#56035)
2024-11-05 [email protected] [Impeller] exploit content context options' perfect hash function. (flutter/engine#56360)
2024-11-05 [email protected] Roll Skia from 7989f782dbf4 to b3be9cb59fe8 (6 revisions) (flutter/engine#56380)
2024-11-05 [email protected] Roll Dart SDK from b39c729740eb to 3e840340c412 (1 revision) (flutter/engine#56377)
2024-11-05 [email protected] [Impeller] match Skia's old VMA default block size. (flutter/engine#56368)
2024-11-05 [email protected] iOS: Refactor ShellTestPlatformViewMetal (flutter/engine#56370)
2024-11-05 [email protected] Roll Fuchsia Linux SDK from amgHXcqtplha8LuI_... to z1otZzn3yKuGnu1st... (flutter/engine#56374)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from amgHXcqtplha to z1otZzn3yKuG

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants