[Flutter GPU] Added support to set Scissor. #56302
Open
+92
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AthulJoseph27
changed the title
AthulJoseph27
force-pushed
the
scissor
branch
from
bb74927
to
64f51e3
Compare
chinmaygarde
approved these changes
Nov 1, 2024
|
The goldens didn't upload for this... not sure why. |
bdero
requested changes
Nov 1, 2024
bdero
reviewed
Nov 2, 2024
AthulJoseph27
force-pushed
the
scissor
branch
from
8951c6d
to
6636a34
Compare
bdero
requested changes
Nov 4, 2024
bdero
requested changes
Nov 4, 2024
lib/gpu/lib/src/render_pass.dart
Outdated
| _validate(); | ||
| } | ||
|
|
||
| final int x, y, width, height; |
There was a problem hiding this comment.
Renderers will often want to iterate on the scissor bounds over time between draws, so allowing all of these properties to be mutable would be more convenient. Otherwise the user will have to make a mirror data structure to do so.
There was a problem hiding this comment.
Done. I have one doubt here though, validate is a private function of Scissor, how is it accessible outside the class?
AthulJoseph27
force-pushed
the
scissor
branch
from
c68bcae
to
33cdd6d
Compare
AthulJoseph27
force-pushed
the
scissor
branch
from
33cdd6d
to
a967f2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to set scissors. This resolves issue #157199