Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode UIView's creation parameters and pass them to the view factory. #6715

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Decode UIView's creation parameters and pass them to the view factory. #6715

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f492a63
Decode UIView's creation parameters and pass them to the view factory.
Oct 31, 2018
94e0cd9
review comments followup
Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,19 @@
return;
}

// TODO(amirh): decode and pass the creation args.
id params = nil;
if ([factory respondsToSelector:@selector(createArgsCodec)]) {
NSObject<FlutterMessageCodec>* codec = [factory createArgsCodec];
if (codec != nil && args[@"params"] != nil) {
FlutterStandardTypedData* paramsData = args[@"params"];
params = [codec decode:paramsData.data];
}
}

FlutterTouchInterceptingView* view = [[[FlutterTouchInterceptingView alloc]
initWithEmbeddedView:[factory createWithFrame:CGRectZero viewIdentifier:viewId arguments:nil]
initWithEmbeddedView:[factory createWithFrame:CGRectZero
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This line is getting a bit long, can you add that embedded view as a variable so its easier to read?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

viewIdentifier:viewId
arguments:params]
flutterView:flutter_view_] autorelease];
views_[viewId] = fml::scoped_nsobject<FlutterTouchInterceptingView>([view retain]);

Expand Down