Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc… #6820

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Revert "Roll Dart version to f9ebf2129732fd2b606286fdf58e500384b8a0bc… #6820

merged 1 commit into from
Nov 10, 2018

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Nov 10, 2018 •
edited
Loading

… (#6812)"

This reverts commit 2584816.

Breaks flutter_gallery_ios32__transition_perf devicelab test upstream in flutter (previous commit works). Stack trace:

Will land TBR @a-siva

/cc @amirh

[flutter_gallery_ios32__transition_perf] [STDOUT] stdout: ../../third_party/dart/runtime/vm/dart_api_impl.cc: 5036: error: expected: klass.has_pragma()
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout: Dumping native stack trace for thread 9f03
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100eccfcc] Dart_DumpNativeStackTrace
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100eccfcc] Dart_DumpNativeStackTrace
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100f27a80] dart::Assert::Fail(char const*, ...)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100ecba58] Dart_LibraryUrl
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100c0ac88] tonic::DartClassLibrary::GetAndCacheClass(char const*, char const*, _Dart_Handle**)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100983748] tonic::(anonymous namespace)::GetTextBoxType()
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100980a20] blink::Paragraph_getRectsForRange(_Dart_NativeArguments*)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100d8c648] dart::NativeEntry::AutoScopeNativeCallWrapperNoStackCheck(_Dart_NativeArguments*, void (*)(_Dart_NativeArguments*))
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100d8d5ec] dart::NativeEntry::LinkNativeCall(_Dart_NativeArguments*)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101804978] kDartVmSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x000000010198ac8c] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x000000010198c8d0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101ab25b0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101ec5fd4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101ec68c4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe474] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a92dc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a92dc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe5bc] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a92dc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101b9bfe4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101ba1df8] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101c0fff4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101c107f0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101eb9a18] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe8d0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d2f68] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101ec8ce0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d19e0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d1764] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d1268] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc54] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a97f30] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a9bda0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe5bc] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101eea274] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101eea274] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d19e0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d1764] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d1268] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc54] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101ed5598] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a97f30] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a9bda0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x000000010200b490] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101abe780] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cfc84] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101b1b180] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019cffc4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d19e0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001019d1764] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101b34bec] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101f18424] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101f17fc8] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101f17ec0] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101f17dd4] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a0f674] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101a0ee68] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101f3e770] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000101f3e858] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001020bf830] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x000000010204b630] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000102052bf8] kDartIsolateSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x000000010180456c] kDartVmSnapshotInstructions
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100d5c300] dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100de57a0] dart::Library::Invoke(dart::String const&, dart::Array const&, dart::Array const&, bool) const
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100ec2f60] Dart_Invoke
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100c10748] tonic::DartInvokeField(_Dart_Handle*, char const*, std::initializer_list<_Dart_Handle*>)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001009863c8] blink::Window::BeginFrame(fml::TimePoint)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001009963dc] shell::Engine::BeginFrame(fml::TimePoint)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100992dd8] std::__1::__function::__func<shell::Animator::AwaitVSync()::$_2, std::__1::allocator<shell::Animator::AwaitVSync()::$_2>, void (fml::TimePoint, fml::TimePoint)>::operator()(fml::TimePoint&&, fml::TimePoint&&)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x000000010095373c] std::__1::function<void (fml::TimePoint, fml::TimePoint)>::operator()(fml::TimePoint, fml::TimePoint) const
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001009a7c2c] std::__1::__function::__func<shell::VsyncWaiter::FireCallback(fml::TimePoint, fml::TimePoint)::$_0, std::__1::allocator<shell::VsyncWaiter::FireCallback(fml::TimePoint, fml::TimePoint)::$_0>, void ()>::operator()()
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100961080] fml::MessageLoopImpl::RunExpiredTasks()
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100962324] fml::MessageLoopDarwin::OnTimerFire(__CFRunLoopTimer*, fml::MessageLoopDarwin*)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001f692ebf0] <redacted>
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001f692e920] <redacted>
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001f692e154] <redacted>
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001f6929030] <redacted>
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001f69285b8] CFRunLoopRunSpecific
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001009621b0] fml::MessageLoopDarwin::Run()
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x0000000100961b5c] void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0> >(void*)
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001f65b92fc] <redacted>
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout:   [0x00000001f65b925c] _pthread_start
[flutter_gallery_ios32__transition_perf] [STDOUT] stdout: -- End of DumpStackTrace

@dnfield dnfield merged commit a5bc335 into flutter:master Nov 10, 2018
This was referenced Nov 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnfield @googlebot