Fix code smells reported by chrome's clang plugin #6833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Nov 13, 2018
| @@ -8,6 +8,10 @@ | |||
|
|
|||
| namespace blink { | |||
|
|
|||
| Settings::Settings() = default; | |||
There was a problem hiding this comment.
We usually add an empty line between method methods. Here and elsewhere in this commit.
There was a problem hiding this comment.
Fixed. I was expecting that clang-format would add those spaces for me. I guess it's not that smart...
goderbauer
force-pushed
the
fixChromeStyle
branch
from
9f8e328
to
f5fc055
Compare
goderbauer
force-pushed
the
fixChromeStyle
branch
from
f5fc055
to
812860f
Compare
aam
reviewed
Nov 13, 2018
| box->DestroyValue(); | ||
| delete box; | ||
| } | ||
|
|
||
| public: | ||
| ThreadLocal() : ThreadLocal(nullptr) {} |
There was a problem hiding this comment.
This change didn't seem to take into account #else branch further down at line 112
There was a problem hiding this comment.
Yeah, sorry about that. Will have a fix first thing in the morning.
Windows Engine Bot is also failing because of this. Did you see a failure anywhere else?
goderbauer
added a commit
to goderbauer/engine
that referenced
this pull request
Nov 13, 2018
Follow-up to flutter#6833
Merged
This was referenced Nov 13, 2018
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2018
flutter/engine@4959b71...520746e git log 4959b71..520746e --no-merges --oneline 520746e Roll src/third_party/skia 14b9f537c5ee..1e00aebd9a45 (5 commits) (flutter/engine#6848) 97b6293 Add missing pragma directive. (flutter/engine#6847) 0d02877 Avoid a never-disappearing splash screen if the engine came from somewhere else on iOS (flutter/engine#6834) 71ade82 Roll src/third_party/skia abde1adc5f0c..14b9f537c5ee (9 commits) (flutter/engine#6846) 4e89aa2 Roll src/third_party/skia 60b6bc3c2950..abde1adc5f0c (6 commits) (flutter/engine#6845) 6a132f8 Fix Windows Engine Bot (flutter/engine#6844) e6d6f18 - Roll engine to version f9ebf2129732fd2b606286fdf58e500384b8a0bc (flutter/engine#6839) 889f41f Roll src/third_party/skia 9e3109c99ea5..60b6bc3c2950 (1 commits) (flutter/engine#6843) a68e214 Roll src/third_party/skia 1e1ba0e0176f..9e3109c99ea5 (1 commits) (flutter/engine#6840) 1174193 Roll src/third_party/skia f04fb3cacbad..1e1ba0e0176f (2 commits) (flutter/engine#6838) 09ef73f Fix code smells reported by chrome's clang plugin (flutter/engine#6833) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues listed in https://www.chromium.org/developers/coding-style/chromium-style-checker-errors for the android and ios release targets. The issues were identified by compiling the engine with the chrome-style clang plugin.
Fixing these issues is supposed to prevent code size bloat. For our code base I am only seeing a rather disappointing reduction of 317 Bytes for
libflutter.so(uncompressed).