Set and unset accessibility flags even when re-entrant #6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took a quick look at the iOS side and noticed a similar issue - these methods can be called where enabled is true both times for a given feature, so we should avoid using XOR. |
dnfield
changed the title
jonahwilliams
approved these changes
Nov 14, 2018
| flags ^= static_cast<int32_t>(blink::AccessibilityFeatureFlag::kReduceMotion); | ||
| if (UIAccessibilityIsBoldTextEnabled()) | ||
| flags ^= static_cast<int32_t>(blink::AccessibilityFeatureFlag::kBoldText); | ||
| if (UIAccessibilityIsInvertColorsEnabled()) { |
There was a problem hiding this comment.
This is unnecessary, flags is built up from 0 every time
There was a problem hiding this comment.
Ahh I missed that. I'm still inclined to change these all to |= as we don't actually want these to toggle, we just want to set them. Sound good to you?
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2018
flutter/engine@b10b8e8...114d33d git log b10b8e8..114d33d --no-merges --oneline 114d33d Set and unset accessibility flags even when re-entrant (flutter/engine#6853) 396402f Flush UserSettings to window (flutter/engine#6850) 1e7e676 Remove unused import (flutter/engine#6854) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
^=was toggling these instead of setting them when they're enabled - this caused part of what is noted in flutter/flutter#20388, but I'd like to leave that bug open even if this lands - I suspect that we should be resetting some internal state of the a11y bridges that we're not, but need to confirm./cc @matthew-carroll in case this impacts the embedding refactor