Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate forwarding for didReceiveLocalNotification and willPresentNotification #6858

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Delegate forwarding for didReceiveLocalNotification and willPresentNotification #6858

merged 1 commit into from
Nov 14, 2018

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Nov 14, 2018

dnfield
dnfield approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkonyi bkonyi merged commit f23862b into master Nov 14, 2018
@bkonyi bkonyi deleted the notification_delegates branch November 14, 2018 19:39
@bkonyi bkonyi mentioned this pull request Nov 14, 2018
Closed
This was referenced Nov 14, 2018
Closed
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Nov 15, 2018
@engine-flutter-autoroll
Roll engine 289de46..498bbd5 (3 commits) (#24364)
e8eea83 
flutter/engine@289de46...498bbd5

git log 289de46..498bbd5 --no-merges --oneline
498bbd5 Roll src/third_party/skia f152130ef910..44764000b49c (8 commits) (flutter/engine#6860)
f23862b Added delegate forwarding for didReceiveLocalNotification and willPresentNotification (flutter/engine#6858)
110a5f3 Reset a11y bridge state on hot restart (flutter/engine#6857)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Jun 12, 2019
Closed
Merged
@bparrishMines bparrishMines mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
affects: dev experience cla: yes platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkonyi @chinmaygarde @dnfield @googlebot