Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard the service protocol's global handlers list with a reader/writer lock (#6888) #6895

Merged
merged 1 commit into from
Nov 18, 2018
Merged

Guard the service protocol's global handlers list with a reader/writer lock (#6888) #6895

merged 1 commit into from
Nov 18, 2018

Commits on Nov 17, 2018

  1. Guard the service protocol's global handlers list with a reader/write… 

    …r lock (flutter#6888)

The service protocol holds the lock while waiting for completion of service
RPC tasks.  These tasks (specifically hot restart/RunInView) may need to
modify a handler's description data.

Task execution and ServiceProtocol::SetHandlerDescription will obtain a shared
lock to make this possible.  AddHandler and RemoveHandler will obtain an
exclusive lock in order to guard against a handler being deleted while a
service task is running.
    @jason-simmons
    jason-simmons committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    5caadbb View commit details
    Browse the repository at this point in the history