Workaround for Drawer.initState() fails #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as Drawer ignoring the |
HansMuller
pushed a commit
that referenced
this pull request
Aug 20, 2015
Workaround for Drawer.initState() fails This is a hack to avoid #715 In theory, the navigator's state should be updated in the event handler that triggers opening the drawer. It's not obvious how to do this, since we only build the Drawer when it's supposed to be visible (and once we're building it's too late).
|
IMHO we should fix this correctly now, not check in workarounds. Otherwise we're just digging ourselves into technical debt. |
|
I will make a proposal for a better fix. |
|
I just tripped over this technical debt. I think it may be implicated in the weird assertions we've been getting. This is why I didn't want us to check in a workaround. |
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Use Stdout.terminalColumns for line length Fall back on a 200-character default, which is less likely to obscure test names when printing to a non-terminal destination. Closes flutter#86
aam
added a commit
to aam/engine
that referenced
this pull request
Apr 18, 2023
Changes since last roll: ``` 059d155 [dart] Add identifier needed for zlib roll (flutter#718) 459d3e5 Bump github/codeql-action from 2.2.11 to 2.2.12 (flutter#716) 91f1ba5 Bump actions/checkout from 3.5.1 to 3.5.2 (#715) 2e5c483 Bump actions/checkout from 3.5.0 to 3.5.1 (flutter#714) a5af13d Remove codeql. (flutter#713) ```
itekdev
pushed a commit
to itekdev/flutter-engine0
that referenced
this pull request
May 1, 2023
Bump github/codeql-action from 2.2.11 to 2.2.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack to avoid #715
In theory, the navigator's state should be updated in the event handler that triggers opening the drawer. It's not obvious how to do this, since we only build the Drawer when it's supposed to be visible (and once we're building it's too late). Perhaps responsibility needs to be borne by the StockHome class?