Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate framework_smoke.py to use RBE instead of GOMA #142986

Closed
zanderso opened this issue Feb 6, 2024 · 2 comments
Closed

Migrate framework_smoke.py to use RBE instead of GOMA #142986

zanderso opened this issue Feb 6, 2024 · 2 comments
Assignees
@keyonghan
Labels
team-infra Owned by Infrastructure team

Comments

@zanderso
Copy link
Member

zanderso commented Feb 6, 2024

The build here can be safely migrated to use RBE: https://flutter.googlesource.com/recipes/+/refs/heads/main/recipes/engine/framework_smoke.py#46.

cc @keyonghan
@zanderso zanderso added the team-infra Owned by Infrastructure team label Feb 6, 2024
@keyonghan keyonghan mentioned this issue Feb 6, 2024
Merged
@keyonghan keyonghan self-assigned this Feb 6, 2024
auto-submit bot pushed a commit to flutter/engine that referenced this issue Feb 6, 2024
@keyonghan
Add use_rbe to gclient variables for Framework Smoke Tests (#50403)
b2ba57e 
This is to enable rbe support. Part of flutter/flutter#142986
@zanderso
Copy link
Member Author

zanderso commented Mar 5, 2024

I believe this is obsolete.

@zanderso zanderso closed this as completed Mar 5, 2024
@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keyonghan keyonghan

Labels
team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zanderso @keyonghan