Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac mac_host_engine sub builds may timeout when also installing Xcode #150011

Closed
Tracked by #148882
vashworth opened this issue Jun 10, 2024 · 3 comments · Fixed by flutter/engine#53355
Closed
Tracked by #148882

Mac mac_host_engine sub builds may timeout when also installing Xcode #150011

vashworth opened this issue Jun 10, 2024 · 3 comments · Fixed by flutter/engine#53355
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team

Comments

@vashworth
Copy link
Contributor

vashworth commented Jun 10, 2024

It seems that sub builds of Mac mac_host_engine have a time limit of 1 hour, however, the builds tend to take ~45 minutes. When it runs on a newly upgrade Mac-14 host, it may timeout if Xcode is also being re-installed, which will push the time it takes over an hour.

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20mac_host_engine/10985/infra

@vashworth vashworth added P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team engine flutter/engine repository. See also e: labels. labels Jun 10, 2024
@vashworth vashworth changed the title Mac mac_host_engine sub builds may timeout with Mac-14 Mac mac_host_engine sub builds may timeout when also installing Xcode Jun 10, 2024
auto-submit bot pushed a commit to flutter/engine that referenced this issue Jun 10, 2024
@vashworth
Copy link
Contributor Author

CL to allow build configs in engine to set a timeout: https://flutter-review.googlesource.com/c/recipes/+/57980

build config would look like this:

{
    "builds": [
        {
            "name": "ci/mac_debug_arm64",
            ...
            "properties": {
                "$flutter/osx_sdk": {
                    "sdk_version": "15a240d",
                    "cleanup_cache": true
                }
            },
            ...
+           "timeout": 10
        },
        ....

@jmagman
Copy link
Member

jmagman commented Jun 10, 2024

CL to allow build configs in engine to set a timeout: https://flutter-review.googlesource.com/c/recipes/+/57980

cc @cbracken flutter/engine#52913

auto-submit bot pushed a commit to flutter/engine that referenced this issue Jun 13, 2024
#53355)

Allow Mac mac_host_engine tests to run for up to 90 minutes (previously assumed 60) and allow the tests to run on Mac-14. This should give the test more time when it needs to do additional tasks like install Xcode.

Timeout was recently added in https://flutter-review.googlesource.com/c/recipes/+/57980.

Timeout tested in https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/941415/infra (timeout set to 4 minutes).

Fixes flutter/flutter#150011.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list team-ios Owned by iOS platform team triaged-ios Triaged by iOS platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants