Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateChildren() needs to walk the list forward #182

Closed
FlutterIssues opened this issue Nov 9, 2015 · 2 comments · Fixed by #1400
Closed

updateChildren() needs to walk the list forward #182

FlutterIssues opened this issue Nov 9, 2015 · 2 comments · Fixed by #1400
Assignees
@abarth
Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Comments

@FlutterIssues
Copy link

Issue by Hixie
Monday Oct 05, 2015 at 21:59 GMT
Originally opened as https://github.com/flutter/engine/issues/1495

When you have a block with multiple focusable controls, the first one needs to get the focus. This means the first one needs to be the first to be built, so it's the first that calls build() and thus the first that calls Focus.at(). However, right now updateChildren() walks the list backwards which means the last child gets the focus.

We probably want to separate the creation of the Element nodes and the setting of the slots from the actual building of the children, somehow, so we can still walk the list backwards to create the slots but walk it forwards to build.
@FlutterIssues FlutterIssues added this to the Blue Sky milestone Nov 9, 2015
@FlutterIssues FlutterIssues added bug framework flutter/packages/flutter repository. See also f: labels. labels Nov 9, 2015
@Hixie
Copy link
Contributor

Hixie commented Dec 16, 2015

Another side-effect of this is that if you have a list of images, we load the images bottom-first. That's weird-looking.

@abarth abarth added the a: text input Entering text in a text field or keyboard related problems label Jan 22, 2016
@abarth abarth self-assigned this Jan 26, 2016
@abarth abarth mentioned this issue Jan 27, 2016
Merged
abarth added a commit to abarth/flutter that referenced this issue Jan 27, 2016
@abarth
updateChildren() needs to walk the list forward
05839e5 
This patch changes the framework to walk the child list forwards so that build
functions with global side effects do sensible things. Specifically, if you
have a number of autofocusable children, the first one the list will acquire
the focus because it gets built first now.

Fixes flutter#182
@ppolasek ppolasek mentioned this issue Feb 8, 2017
Closed
@jamesgopinath jamesgopinath mentioned this issue Aug 4, 2017
Closed
@arnold-nonstop arnold-nonstop mentioned this issue Sep 29, 2017
Closed
@steele232 steele232 mentioned this issue Nov 9, 2017
Closed
@wiltwitt wiltwitt mentioned this issue Mar 24, 2018
Closed
@kuochaoyi kuochaoyi mentioned this issue Mar 28, 2018
Closed
@micrcx micrcx mentioned this issue Mar 31, 2018
Closed
@bourrhia bourrhia mentioned this issue Apr 3, 2018
Closed
@codigo47 codigo47 mentioned this issue Apr 12, 2018
Closed
@rashedmyt rashedmyt mentioned this issue Apr 15, 2018
Closed
@Rockvole Rockvole mentioned this issue Apr 16, 2018
Closed
@efidje efidje mentioned this issue May 8, 2018
Closed
@shallquist shallquist mentioned this issue May 14, 2018
Closed
@NTMS2017 NTMS2017 mentioned this issue May 17, 2018
Closed
@JigneshWorld JigneshWorld mentioned this issue May 21, 2018
Closed
@sahil311289 sahil311289 mentioned this issue Jun 23, 2018
Closed
@daniele777 daniele777 mentioned this issue Dec 9, 2019
Closed
This was referenced Dec 13, 2019
Closed
Closed
This was referenced Dec 16, 2019
Closed
Closed
This was referenced Dec 17, 2019
Closed
Closed
This was referenced Jan 4, 2020
Closed
Closed
This was referenced Jan 11, 2020
Closed
Closed
Closed
@viratshukla viratshukla mentioned this issue Jan 16, 2020
Closed
@azheennn azheennn mentioned this issue Jan 19, 2020
Closed
@allenbrunson allenbrunson mentioned this issue Feb 19, 2020
Closed
@qylshy qylshy mentioned this issue Feb 24, 2020
Closed
@varunkamani varunkamani mentioned this issue Mar 4, 2020
Closed
@GLopesRio GLopesRio mentioned this issue Mar 18, 2020
Closed
@davidakinfenwa davidakinfenwa mentioned this issue May 5, 2020
Closed
@AtomicMaya AtomicMaya mentioned this issue May 11, 2020
Closed
@geovin89 geovin89 mentioned this issue Jun 21, 2020
Closed
@xu-baolin xu-baolin mentioned this issue Jul 27, 2020
Merged
13 tasks
@verinder84 verinder84 mentioned this issue Aug 29, 2020
Closed
@l1x2d3 l1x2d3 mentioned this issue Sep 8, 2020
Closed
@flow-rajkarthik flow-rajkarthik mentioned this issue Sep 10, 2020
Closed
@dahmaular dahmaular mentioned this issue Sep 15, 2020
Closed
@Bibooo25730 Bibooo25730 mentioned this issue Oct 18, 2020
Closed
@samaddestring samaddestring mentioned this issue Dec 2, 2020
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abarth abarth

Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updateChildren() needs to walk the list forward abarth/flutter
3 participants
@abarth @Hixie @FlutterIssues