Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "Clipping if only one character text overflows" #102130

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Reland "Clipping if only one character text overflows" #102130

merged 1 commit into from
Jun 29, 2022

Conversation

xu-baolin
Copy link
Member

Do not merge before @justinmc LGTMing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Apr 19, 2022
@xu-baolin
Copy link
Member Author

@justinmc Thanks very much for investigating the G test.

@goderbauer
Copy link
Member

(triage) @justinmc @xu-baolin Any updates on this one?

@justinmc
Copy link
Contributor

Sorry, I've triggered the Google tests on this, but the new approach looks good. I'll check in on the Google tests tomorrow.

@justinmc
Copy link
Contributor

Looks like the Google tests never ran. I'm trying to figure out how to get that check to show up here...

justinmc
justinmc approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm under the impression that Google tests won't run until the PR has been approved, so I'm approving this for that reason, but it should not be merged yet!

@justinmc
Copy link
Contributor

@xu-baolin I'm still struggling to get the Google tests to run... Can you rebase this onto master so that we get a different commit SHA?

@xu-baolin xu-baolin force-pushed the revert-102092-revert-99146-xbl000225 branch from 5408e68 to e1f6ab1 Compare May 18, 2022 07:58
@xu-baolin
Copy link
Member Author

@xu-baolin I'm still struggling to get the Google tests to run... Can you rebase this onto master so that we get a different commit SHA?

Done
Thanks a lot

@goderbauer
Copy link
Member

Although the status was not reported back to github, it looks like the tests finished running. There are some failures, but they look very minor. @justinmc WDYT?

@Piinks
Copy link
Contributor

Piinks commented Jun 22, 2022

(Triage) @justinmc what is the status of this PR?

@justinmc
Copy link
Contributor

I'm struggling with getting frob to work for this PR. I'm going to merge it and and follow up on any test failures.

@justinmc justinmc merged commit 3f43d9f into master Jun 29, 2022
@justinmc justinmc deleted the revert-102092-revert-99146-xbl000225 branch June 29, 2022 21:57
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2022
@engine-flutter-autoroll
3f43d9f Reland "Clipping if only one character text overflows (#99146…
684dd2e 
…)" (flutter/flutter#102130)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 30, 2022
@engine-flutter-autoroll
3f43d9f Reland "Clipping if only one character text overflows (#99146…
6d1fa5b 
…)" (flutter/flutter#102130)
XilaiZhang added a commit to XilaiZhang/flutter that referenced this pull request Jul 1, 2022
@XilaiZhang
Revert "Reland "Clipping if only one character text overflows (flutte…
031d597 
…r#99146)" (flutter#102130)"

This reverts commit 3f43d9f.
@XilaiZhang XilaiZhang mentioned this pull request Jul 1, 2022
Merged
XilaiZhang added a commit to XilaiZhang/flutter that referenced this pull request Jul 1, 2022
@XilaiZhang
Revert "Reland "Clipping if only one character text overflows (flutte…
9c54077 
…r#99146)" (flutter#102130)"

This reverts commit 3f43d9f.
XilaiZhang added a commit to XilaiZhang/flutter that referenced this pull request Jul 1, 2022
@XilaiZhang
Revert "Reland "Clipping if only one character text overflows (flutte…
915ab5d 
…r#99146)" (flutter#102130)"

This reverts commit 3f43d9f.
@XilaiZhang XilaiZhang mentioned this pull request Jul 1, 2022
Merged
XilaiZhang added a commit that referenced this pull request Jul 1, 2022
@XilaiZhang
Revert "Reland "Clipping if only one character text overflows (#99146)…
03e2720 
…" (#102130)" (#106967)

This reverts commit 3f43d9f.
XilaiZhang added a commit that referenced this pull request Jul 1, 2022
@XilaiZhang
Revert "Reland "Clipping if only one character text overflows (#99146)…
a7fe235 
…" (#102130)" (#106964)

This reverts commit 3f43d9f.
winctoryang pushed a commit to winctoryang/flutter that referenced this pull request Jul 6, 2022
@XilaiZhang
[g3 roll] revert flutter#105537 Implement frameData for TestWindow (f…
d6f090d 
…lutter#107168)

* Revert "Reland "Clipping if only one character text overflows (flutter#99146)" (flutter#102130)"

This reverts commit 3f43d9f.

* Revert "Implement frameData for TestWindow (flutter#105537)"

This reverts commit 21841d7.
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@xu-baolin @camsim99
Reland "Clipping if only one character text overflows (flutter#99146)" (
c7c3f5d 
flutter#102130)

Fixes a text clipping edge case.
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@XilaiZhang @camsim99
Revert "Reland "Clipping if only one character text overflows (flutte…
2a5faee 
…r#99146)" (flutter#102130)" (flutter#106964)

This reverts commit 3f43d9f.
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@XilaiZhang @camsim99
[g3 roll] revert flutter#105537 Implement frameData for TestWindow (f…
d548b2c 
…lutter#107168)

* Revert "Reland "Clipping if only one character text overflows (flutter#99146)" (flutter#102130)"

This reverts commit 3f43d9f.

* Revert "Implement frameData for TestWindow (flutter#105537)"

This reverts commit 21841d7.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
3f43d9f Reland "Clipping if only one character text overflows (#99146…
9d8f65a 
…)" (flutter/flutter#102130)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
3f43d9f Reland "Clipping if only one character text overflows (#99146…
f022dde 
…)" (flutter/flutter#102130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xu-baolin @goderbauer @justinmc @Piinks