[macOS,iOS] CocoaPods recommended version: 1.13.0 #135447

cbracken · 2023-09-25T17:36:31Z

Due to changes in Xcode 15, several variables such as DT_TOOLCHAIN_DIR have been eliminateed in favour of others such as TOOLCHAIN_DIR. This broke CocoaPods support under Xcode 15, as reported in: CocoaPods/CocoaPods#12012

@vashworth worked around this in Flutter in:
#132803

The CocoaPods issue was resolved by the following PR to their repo: CocoaPods/CocoaPods#12009
and was released in CocoaPods 1.13.0.

Also switches from an if-else chain to a switch for CocoaPodsStatus handling.

Related: #133584
Related: #132755

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

vashworth

The code LGTM, but I don't know that we should recommend a new version without running our CI against it first.

vashworth · 2023-09-25T17:51:02Z

There's an outstanding issue for upgrading our CI to 1.12.1 #133096, which was blocked by #122057

cbracken · 2023-09-25T17:54:08Z

Yes - we should definitely update CI before landing this.

cbracken · 2023-09-25T17:56:47Z

Actually, what I'll do to minimise this patch is separate out the refactor to using a case statement and adding the upgrade string from the actual version bump. When the next version bump comes along, whoever does it would probably appreciate having the previous patch as minimal as possible.

I've sent out #135453 for the refactor and rebased this on top of it.

@vashworth

Due to changes in Xcode 15, several variables such as `DT_TOOLCHAIN_DIR` have been eliminateed in favour of others such as `TOOLCHAIN_DIR`. This broke CocoaPods support under Xcode 15, as reported in: CocoaPods/CocoaPods#12012 @vashworth worked around this in Flutter in: flutter#132803 The CocoaPods issue was resolved by the following PR to their repo: CocoaPods/CocoaPods#12009 and was released in CocoaPods 1.13.0. Also switches from an if-else chain to a switch for CocoaPodsStatus handling. Issue: flutter#133584 Related: flutter#132755

christopherfujino · 2023-10-19T20:49:18Z

I believe this is blocked on updating the way we get ruby on our mac bots

cbracken · 2023-10-19T22:36:15Z

Yep - that, and then updating our own bots is what this is waiting on.

gspencergoog · 2023-11-02T18:18:56Z

@godofredoc What is the status of updating Cocoapods on the bots? (Desktop Triage)

christopherfujino · 2023-12-01T20:36:15Z

@cbracken I think we're unblocked after #136929

christopherfujino

LGTM

…utter#135447)

flutter/flutter@2407f69...cdc83e5 2023-12-18 [email protected] Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) (flutter/flutter#140309) 2023-12-18 [email protected] refactored cli tool ipa method name to support --export-options-plist (flutter/flutter#138555) 2023-12-18 [email protected] Restore and fix flavors_test_macos (flutter/flutter#139841) 2023-12-18 [email protected] Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) (flutter/flutter#140308) 2023-12-17 [email protected] Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) (flutter/flutter#140291) 2023-12-17 [email protected] Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) (flutter/flutter#140289) 2023-12-16 [email protected] Roll Flutter Engine from c5fc179cf0b3 to 726a137e3f99 (1 revision) (flutter/flutter#140280) 2023-12-16 [email protected] Roll Flutter Engine from a8d8fbbcef22 to c5fc179cf0b3 (1 revision) (flutter/flutter#140277) 2023-12-16 [email protected] Center Floating Snackbar with custom width when direction is RTL (flutter/flutter#140215) 2023-12-16 [email protected] Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (flutter/flutter#140274) 2023-12-16 [email protected] Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942) 2023-12-16 [email protected] Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (flutter/flutter#140270) 2023-12-16 [email protected] Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (flutter/flutter#140268) 2023-12-16 [email protected] Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (flutter/flutter#140265) 2023-12-16 [email protected] Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (flutter/flutter#140263) 2023-12-16 [email protected] Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (flutter/flutter#140262) 2023-12-16 [email protected] [github actions] minor PR to test latest github actions (flutter/flutter#140252) 2023-12-16 [email protected] Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (flutter/flutter#140255) 2023-12-15 [email protected] Remove usage of testWidgetsWithLeakTracking. (flutter/flutter#140239) 2023-12-15 [email protected] Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (flutter/flutter#140244) 2023-12-15 [email protected] Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (flutter/flutter#140240) 2023-12-15 [email protected] Use new `enabledFeature` param for `Analytics` (flutter/flutter#139934) 2023-12-15 [email protected] Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (flutter/flutter#140236) 2023-12-15 [email protected] Reorganize dependencies on leak_tracker. (flutter/flutter#140233) 2023-12-15 [email protected] [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/flutter#135447) 2023-12-15 [email protected] Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (flutter/flutter#140230) 2023-12-15 [email protected] Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (flutter/flutter#140228) 2023-12-15 [email protected] Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (flutter/flutter#140224) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter#135447)

flutter/flutter@2407f69...cdc83e5 2023-12-18 [email protected] Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) (flutter/flutter#140309) 2023-12-18 [email protected] refactored cli tool ipa method name to support --export-options-plist (flutter/flutter#138555) 2023-12-18 [email protected] Restore and fix flavors_test_macos (flutter/flutter#139841) 2023-12-18 [email protected] Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) (flutter/flutter#140308) 2023-12-17 [email protected] Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) (flutter/flutter#140291) 2023-12-17 [email protected] Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) (flutter/flutter#140289) 2023-12-16 [email protected] Roll Flutter Engine from c5fc179cf0b3 to 726a137e3f99 (1 revision) (flutter/flutter#140280) 2023-12-16 [email protected] Roll Flutter Engine from a8d8fbbcef22 to c5fc179cf0b3 (1 revision) (flutter/flutter#140277) 2023-12-16 [email protected] Center Floating Snackbar with custom width when direction is RTL (flutter/flutter#140215) 2023-12-16 [email protected] Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (flutter/flutter#140274) 2023-12-16 [email protected] Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942) 2023-12-16 [email protected] Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (flutter/flutter#140270) 2023-12-16 [email protected] Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (flutter/flutter#140268) 2023-12-16 [email protected] Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (flutter/flutter#140265) 2023-12-16 [email protected] Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (flutter/flutter#140263) 2023-12-16 [email protected] Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (flutter/flutter#140262) 2023-12-16 [email protected] [github actions] minor PR to test latest github actions (flutter/flutter#140252) 2023-12-16 [email protected] Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (flutter/flutter#140255) 2023-12-15 [email protected] Remove usage of testWidgetsWithLeakTracking. (flutter/flutter#140239) 2023-12-15 [email protected] Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (flutter/flutter#140244) 2023-12-15 [email protected] Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (flutter/flutter#140240) 2023-12-15 [email protected] Use new `enabledFeature` param for `Analytics` (flutter/flutter#139934) 2023-12-15 [email protected] Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (flutter/flutter#140236) 2023-12-15 [email protected] Reorganize dependencies on leak_tracker. (flutter/flutter#140233) 2023-12-15 [email protected] [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/flutter#135447) 2023-12-15 [email protected] Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (flutter/flutter#140230) 2023-12-15 [email protected] Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (flutter/flutter#140228) 2023-12-15 [email protected] Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (flutter/flutter#140224) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

cbracken requested a review from vashworth September 25, 2023 17:36

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Sep 25, 2023

cbracken mentioned this pull request Sep 25, 2023

Update Cocoapods version in CI after DT_TOOLCHAIN_DIR fix is in an official release #133584

Closed

cbracken requested a review from christopherfujino September 25, 2023 17:45

vashworth reviewed Sep 25, 2023

View reviewed changes

cbracken force-pushed the cocoapods-version-bump branch 2 times, most recently from 00e89a0 to f1e8108 Compare September 26, 2023 16:38

cbracken force-pushed the cocoapods-version-bump branch from f1e8108 to f0dae20 Compare September 26, 2023 16:43

cbracken mentioned this pull request Sep 26, 2023

Cannot install CocoaPods 1.12 in CI, failed installing dependency json 2.6.3 with native extensions #122057

Closed

Merge branch 'master' into cocoapods-version-bump

72a6b3a

christopherfujino approved these changes Dec 14, 2023

View reviewed changes

cbracken merged commit d0670f0 into flutter:master Dec 15, 2023
121 checks passed

cbracken deleted the cocoapods-version-bump branch December 15, 2023 19:16

engine-flutter-autoroll mentioned this pull request Dec 16, 2023

Roll Flutter from 2407f699e935 to 3958b3d5ff15 (17 revisions) flutter/packages#5695

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023

d0670f0 [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/fl…

e67404d

…utter#135447)

engine-flutter-autoroll mentioned this pull request Dec 16, 2023

Roll Flutter from 2407f699e935 to 8c02a22403fe (18 revisions) flutter/packages#5696

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023

d0670f0 [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/fl…

9d51971

…utter#135447)

engine-flutter-autoroll mentioned this pull request Dec 16, 2023

Roll Flutter from 2407f699e935 to c1e207d6acb2 (19 revisions) flutter/packages#5697

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023

d0670f0 [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/fl…

0248df6

…utter#135447)

engine-flutter-autoroll mentioned this pull request Dec 17, 2023

Roll Flutter from 2407f699e935 to 32d42b63def2 (24 revisions) flutter/packages#5699

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2023

d0670f0 [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/fl…

b61e03f

…utter#135447)

engine-flutter-autoroll mentioned this pull request Dec 17, 2023

Roll Flutter from 2407f699e935 to 32d42b63def2 (24 revisions) flutter/packages#5700

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2023

d0670f0 [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/fl…

b2da67d

…utter#135447)

engine-flutter-autoroll mentioned this pull request Dec 18, 2023

Roll Flutter from 2407f699e935 to cdc83e5ebae4 (28 revisions) flutter/packages#5715

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2023

d0670f0 [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/fl…

c7ec711

…utter#135447)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

d0670f0 [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/fl…

8d50a83

…utter#135447)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[macOS,iOS] CocoaPods recommended version: 1.13.0 #135447

[macOS,iOS] CocoaPods recommended version: 1.13.0 #135447

cbracken commented Sep 25, 2023

vashworth left a comment

vashworth commented Sep 25, 2023

cbracken commented Sep 25, 2023

cbracken commented Sep 25, 2023 •

edited

Loading

christopherfujino commented Oct 19, 2023

cbracken commented Oct 19, 2023

gspencergoog commented Nov 2, 2023

christopherfujino commented Dec 1, 2023

christopherfujino left a comment

[macOS,iOS] CocoaPods recommended version: 1.13.0 #135447

[macOS,iOS] CocoaPods recommended version: 1.13.0 #135447

Conversation

cbracken commented Sep 25, 2023

Pre-launch Checklist

vashworth left a comment

Choose a reason for hiding this comment

vashworth commented Sep 25, 2023

cbracken commented Sep 25, 2023

cbracken commented Sep 25, 2023 • edited Loading

christopherfujino commented Oct 19, 2023

cbracken commented Oct 19, 2023

gspencergoog commented Nov 2, 2023

christopherfujino commented Dec 1, 2023

christopherfujino left a comment

Choose a reason for hiding this comment

cbracken commented Sep 25, 2023 •

edited

Loading