Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the display of the Overlay on the Slider #139021

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Optimize the display of the Overlay on the Slider #139021

merged 3 commits into from
Dec 4, 2023

Conversation

hgraceb
Copy link
Contributor

@hgraceb hgraceb commented Nov 26, 2023 •
edited
Loading

Description

Automatic focus request on Slider value change prevents Overlay from correctly handling hover events.

Fixes #139281

Before

slider3

After

slider4

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 26, 2023
@hgraceb
Copy link
Contributor Author

hgraceb commented Nov 27, 2023

cc @TahaTesser @Piinks

@TahaTesser TahaTesser self-requested a review November 29, 2023 15:58
@TahaTesser
Copy link
Member

@hgraceb
Can you please link an issue with the details and code sample? If the issue doesn't exist, please file one. Thanks!

@hgraceb hgraceb mentioned this pull request Nov 30, 2023
Closed
2 tasks
@hgraceb
Copy link
Contributor Author

hgraceb commented Nov 30, 2023

@hgraceb Can you please link an issue with the details and code sample? If the issue doesn't exist, please file one. Thanks!

#139281

TahaTesser
TahaTesser requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! This looks good.

packages/flutter/test/material/slider_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/slider_test.dart Outdated Show resolved Hide resolved
TahaTesser
TahaTesser approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Piinks
Piinks approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hgraceb welcome. Thank you for contributing.
This LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 4, 2023
@auto-submit auto-submit bot merged commit 5530c10 into flutter:master Dec 4, 2023
70 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
108b9ac 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
ca6dd7b 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
32fa2fe 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
2d4d721 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
0d8d5f4 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
37cbfb4 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
dc2d024 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
48684aa 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
041112b 
…utter#139021)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
850996f 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
608bd52 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
1b14faa 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
1bcbefc 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
ff8333c 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
9b1882a 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
086f69b 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
a0740c4 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
76fe64a 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
b9bf915 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
1346722 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
4bd2fc1 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
c5c1362 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
c1637ea 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
454c658 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
1be4e72 
…utter#139021)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
c32bd3b 
…utter#139021)
@HansMuller HansMuller mentioned this pull request Dec 15, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
5530c10 Optimize the display of the Overlay on the Slider (flutter/fl…
f5b1be5 
…utter#139021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Material Slider cannot automatically hide the overlay
3 participants
@hgraceb @TahaTesser @Piinks