Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" #143973

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" #143973

merged 1 commit into from
Feb 22, 2024

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Feb 22, 2024 •
edited
Loading

Reverts #138521

Revert reason: the global approval was rejected as the changes to //education are non-trivial. Reverting this PR to unblock roll.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. c: tech-debt Technical debt, code quality, testing, etc. labels Feb 22, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #143973 at sha fa19a26

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 22, 2024
@QuncCccccc QuncCccccc merged commit 4715216 into master Feb 22, 2024
136 checks passed
@QuncCccccc QuncCccccc deleted the revert-138521-introduce_new_color_roles branch February 22, 2024 22:51
@QuncCccccc QuncCccccc mentioned this pull request Feb 23, 2024
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
4715216 Revert "Introduce tone-based surfaces and accent color add-on…
8ffa7f6 
…s - Part 2" (flutter/flutter#143973)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
4715216 Revert "Introduce tone-based surfaces and accent color add-on…
842e372 
…s - Part 2" (flutter/flutter#143973)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
4715216 Revert "Introduce tone-based surfaces and accent color add-on…
56e5401 
…s - Part 2" (flutter/flutter#143973)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
4715216 Revert "Introduce tone-based surfaces and accent color add-on…
dcd6995 
…s - Part 2" (flutter/flutter#143973)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
4715216 Revert "Introduce tone-based surfaces and accent color add-on…
c36318d 
…s - Part 2" (flutter/flutter#143973)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
Roll Flutter from 41581c9 to 39585e6 (31 revisions) (#6194)
fe6111b 
flutter/flutter@41581c9...39585e6

2024-02-23 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144023)
2024-02-23 [email protected] Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028)
2024-02-23 [email protected] Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030)
2024-02-23 [email protected] Run tests on iOS 17 exclusively (flutter/flutter#144022)
2024-02-23 [email protected] Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967)
2024-02-23 [email protected] Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500)
2024-02-23 [email protected] Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961)
2024-02-23 [email protected] Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974)
2024-02-23 [email protected] Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989)
2024-02-23 [email protected] Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983)
2024-02-23 [email protected] Remove unused drone_dimension field (flutter/flutter#143984)
2024-02-23 [email protected] Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960)
2024-02-22 [email protected] Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986)
2024-02-22 [email protected] Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979)
2024-02-22 [email protected] Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980)
2024-02-22 [email protected] Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973)
2024-02-22 [email protected] Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934)
2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971)
2024-02-22 [email protected] Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972)
2024-02-22 [email protected] Use inlining annotations on important methods for all targets (flutter/flutter#143923)
2024-02-22 [email protected] Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771)
2024-02-22 [email protected] Shift Moto G4 staging tests to A02s (flutter/flutter#143957)
2024-02-22 [email protected] Add CurvedAnimation disposals in some widgets (flutter/flutter#143790)
2024-02-22 [email protected] Fix documentation typo in basic.dart (flutter/flutter#143887)
2024-02-22 [email protected] Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
2024-02-22 [email protected] Support using lightweight Flutter Engines to run tests (flutter/flutter#141726)
2024-02-22 [email protected] Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946)
2024-02-22 [email protected] Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935)
2024-02-22 [email protected] Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933)
2024-02-22 [email protected] Reland Add UI Benchmarks (#143542) (flutter/flutter#143799)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit that referenced this pull request Feb 27, 2024
@QuncCccccc
Reland - Introduce tone-based surfaces and accent color add-ons - Par…
871d592 
…t 2 (#144001)

Reverts #143973

This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
@auto-submit auto-submit bot mentioned this pull request Feb 27, 2024
Merged
auto-submit bot added a commit that referenced this pull request Feb 27, 2024
@auto-submit
Reverts "Reland - Introduce tone-based surfaces and accent color add-…
2eee0b5 
…ons - Part 2 (#144001)" (#144262)

Reverts #144001

Initiated by: Piinks

Reason for reverting: Failing goldens at the tip of tree

Original PR Author: QuncCccccc

Reviewed By: {HansMuller}

This change reverts the following previous change:
Original Description:
Reverts #143973

This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@engine-flutter-autoroll @LouiseHsu
Roll Flutter from 41581c9 to 39585e6 (31 revisions) (flutter#6194)
84dc5ff 
flutter/flutter@41581c9...39585e6

2024-02-23 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144023)
2024-02-23 [email protected] Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028)
2024-02-23 [email protected] Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030)
2024-02-23 [email protected] Run tests on iOS 17 exclusively (flutter/flutter#144022)
2024-02-23 [email protected] Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967)
2024-02-23 [email protected] Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500)
2024-02-23 [email protected] Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961)
2024-02-23 [email protected] Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974)
2024-02-23 [email protected] Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989)
2024-02-23 [email protected] Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983)
2024-02-23 [email protected] Remove unused drone_dimension field (flutter/flutter#143984)
2024-02-23 [email protected] Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960)
2024-02-22 [email protected] Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986)
2024-02-22 [email protected] Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979)
2024-02-22 [email protected] Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980)
2024-02-22 [email protected] Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973)
2024-02-22 [email protected] Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934)
2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971)
2024-02-22 [email protected] Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972)
2024-02-22 [email protected] Use inlining annotations on important methods for all targets (flutter/flutter#143923)
2024-02-22 [email protected] Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771)
2024-02-22 [email protected] Shift Moto G4 staging tests to A02s (flutter/flutter#143957)
2024-02-22 [email protected] Add CurvedAnimation disposals in some widgets (flutter/flutter#143790)
2024-02-22 [email protected] Fix documentation typo in basic.dart (flutter/flutter#143887)
2024-02-22 [email protected] Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
2024-02-22 [email protected] Support using lightweight Flutter Engines to run tests (flutter/flutter#141726)
2024-02-22 [email protected] Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946)
2024-02-22 [email protected] Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935)
2024-02-22 [email protected] Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933)
2024-02-22 [email protected] Reland Add UI Benchmarks (#143542) (flutter/flutter#143799)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
4715216 Revert "Introduce tone-based surfaces and accent color add-on…
7dd126d 
…s - Part 2" (flutter/flutter#143973)
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from 41581c9 to 39585e6 (31 revisions) (flutter#6194)
a371ed4 
flutter/flutter@41581c9...39585e6

2024-02-23 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144023)
2024-02-23 [email protected] Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028)
2024-02-23 [email protected] Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030)
2024-02-23 [email protected] Run tests on iOS 17 exclusively (flutter/flutter#144022)
2024-02-23 [email protected] Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967)
2024-02-23 [email protected] Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500)
2024-02-23 [email protected] Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961)
2024-02-23 [email protected] Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974)
2024-02-23 [email protected] Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989)
2024-02-23 [email protected] Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983)
2024-02-23 [email protected] Remove unused drone_dimension field (flutter/flutter#143984)
2024-02-23 [email protected] Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960)
2024-02-22 [email protected] Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986)
2024-02-22 [email protected] Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979)
2024-02-22 [email protected] Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980)
2024-02-22 [email protected] Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973)
2024-02-22 [email protected] Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934)
2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971)
2024-02-22 [email protected] Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972)
2024-02-22 [email protected] Use inlining annotations on important methods for all targets (flutter/flutter#143923)
2024-02-22 [email protected] Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771)
2024-02-22 [email protected] Shift Moto G4 staging tests to A02s (flutter/flutter#143957)
2024-02-22 [email protected] Add CurvedAnimation disposals in some widgets (flutter/flutter#143790)
2024-02-22 [email protected] Fix documentation typo in basic.dart (flutter/flutter#143887)
2024-02-22 [email protected] Fixed Small Typo in Emulators Test Name (flutter/flutter#143578)
2024-02-22 [email protected] Support using lightweight Flutter Engines to run tests (flutter/flutter#141726)
2024-02-22 [email protected] Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946)
2024-02-22 [email protected] Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935)
2024-02-22 [email protected] Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933)
2024-02-22 [email protected] Reland Add UI Benchmarks (#143542) (flutter/flutter#143799)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuncCccccc @CaseyHillers