Implement SelectionArea triple click gestures #144563

Renzo-Olivares · 2024-03-04T20:07:20Z

This change adds support for triple click to select a paragraph at the clicked position and triple click + drag to extend the selection paragraph-by-paragraph when using the SelectionArea widget.

This PR also:

Makes Text widgets a SelectionContainer if a parent SelectionRegistrar exists.
Fixes issues with selectable ordering involving WidgetSpans.

Fixes: #104552

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

justinmc

Looks good overall. This is another clear example of how we don't want to duplicate this kind of complex logic in editable text.

Is this triple click and triple click + drag behavior identical on all platforms?

justinmc · 2024-03-04T22:18:35Z

packages/flutter/lib/src/rendering/paragraph.dart

@@ -424,6 +428,9 @@ class RenderParagraph extends RenderBox with ContainerRenderObjectMixin<RenderBo
    return result;
  }

+  /// The [Selectable]s created by this [RenderParagraph] instance.
+  List<Selectable>? get selectables => _lastSelectableFragments;


Any reason we shouldn't expose this?

I got around exposing this by instead exposing a method that returns a bool. That keeps the actual Selectables private.

justinmc · 2024-03-04T22:24:03Z

packages/flutter/lib/src/rendering/paragraph.dart

-    if (wordBoundary != null) {
-      assert(wordBoundary.wordStart.offset >= range.start && wordBoundary.wordEnd.offset <= range.end);
-      if (_selectableContainsOriginWord && existingSelectionStart != null && existingSelectionEnd != null) {
+    if (textBoundary != null) {


Is it possible to remove a layer of nesting by reversing this if?:

if (textBoundary == null) { return targetPosition ?? position; }

Here and in all the similar methods below.

packages/flutter/lib/src/rendering/paragraph.dart

justinmc · 2024-03-04T22:28:52Z

packages/flutter/lib/src/rendering/paragraph.dart

        }
      }
    }
    return targetPosition ?? position;
  }

-  SelectionResult _updateSelectionEdgeByWord(Offset globalPosition, {required bool isEnd}) {
+  TextPosition _updateSelectionEndEdgeByMultiSelectableTextBoundary(


Nit: Just a drive by comment, but is there any code that could be shared between these 4 similar methods?

justinmc · 2024-03-04T22:32:17Z

packages/flutter/lib/src/rendering/paragraph.dart

+    return _getResultBasedOnParagraphBoundary(positionInFullText);
+  }
+
+  final int _placeholderLength = 1;


This never changes I guess? Should it be static const?

Also maybe leave a comment explaining it.

justinmc · 2024-03-04T22:54:45Z

packages/flutter/lib/src/widgets/text.dart

@@ -713,3 +721,548 @@ class Text extends StatelessWidget {
    }
  }
 }
+
+// In practice some selectables like widgetspan shift several pixels. So when


I didn't realize that, do you know why?

Not exactly sure, but this was introduced in this change #130043 .

packages/flutter/lib/src/widgets/text.dart

justinmc · 2024-03-04T23:08:08Z

packages/flutter/lib/src/widgets/text.dart

@@ -647,14 +650,16 @@ class Text extends StatelessWidget {
      effectiveTextStyle = effectiveTextStyle!.merge(const TextStyle(fontWeight: FontWeight.bold));
    }
    final SelectionRegistrar? registrar = SelectionContainer.maybeOf(context);
+    final GlobalKey? textKey = registrar == null ? null : GlobalKey();
+    final _SelectableTextContainerDelegate? selectionDelegate = registrar == null ? null : _SelectableTextContainerDelegate(textKey!);


When does it happen that there is no SelectionContainer above this, but we still need selectionDelegate?

This would never happen, if I am understanding correctly. The delegate will be null when there is no SelectionContainer above this.

justinmc · 2024-03-04T23:11:54Z

packages/flutter/lib/src/widgets/text.dart

+        }
+      }
+      if (globalRectsContainsPosition) {
+        if (paragraph.selectables != null && !paragraph.selectables!.contains(selectables[index])) {


Can you explain (to me) the difference between selectables and paragraph.selectables? This Text may just be a part of a greater paragraph above?

Yeah, i'll try to explain in depth. So say we have the following Text widget wrapped in a SelectionArea.

Text.rich( // SelectionContainer TextSpan( children: <InlineSpan>[ TextSpan(text: 'This is some text before a widgetspan. '), // selectableA WidgetSpan( child: Text('This is some text in a widgetspan.'), // selectableC ), // SelectionContainer TextSpan(text: ' This is some text after a widgetspan.'), // selectableB ], ), ),

Internally the RenderParagraph of the root Text widget will create 2 selectables, one belonging to the text before the WidgetSpan, and the other belonging to the Text after the WidgetSpan. The root RenderParagraph will not create a selectable for the inline WidgetSpan because we explicitly skip placeholders when iterating through the text to create its selectables. These two selectables are registered to the SelectionContainer belonging to that root Text widget. The RenderParagraph belonging to the Text widget in the WidgetSpan will create one selectable fragment representing its entire text. This selectable fragment is then registered to the SelectionContainer belonging to the WidgetSpan, and that container registers itself to the container of the root Text widget above it. Then the root container registers itself to the root SelectionAreas registrar.

This is how it ends up breaking down:

SelectionArea.selectables = [ RootTextWidgetSelectionContainer ] RootTextWidgetSelectionContainer.selectables = [ selectableA, WidgetSpanSelectionContainer, selectableB ] WidgetSpanSelectionContainer.selectables = [ selectableC ] RootRenderParagraph.selectables = [ selectableA, selectableB ] WidgetSpanRenderParagraph.selectables = [ selectableC ]

I use this breakdown to determine if a given selectable is a placeholder (WidgetSpan), or if it belongs to the root text. Let me know if this was clear. Definitely open to alternatives to adding RenderParagraph.selectables since it could potentially be used incorrectly.

Thanks for the thorough explanation. Where does paragraph.selectables get populated? I'm not seeing it at first glance.

Also, why didn't we need this infrastructure before this PR? It seems like you would need this for selecting by line etc. also.

justinmc · 2024-03-04T23:13:04Z

packages/flutter/lib/src/widgets/text.dart

+    for (int index = 0; index < selectables.length; index += 1) {
+      bool globalRectsContainsPosition = false;
+      if (selectables[index].boundingBoxes.isNotEmpty) {
+        for (final Rect rect in selectables[index].boundingBoxes) {


This method could be a performance bottleneck in a large document, but currently that's true of a lot of places, so probably not a big deal.

Yeah, i'm also not the biggest fan of this, but couldn't come up with a better way to do this logic. What I might be able to do is instead of checking every selectable, I can check only the placeholders which are guaranteed to only have one item in their boundingBoxes list because they are SelectionContainers

flutter/packages/flutter/lib/src/widgets/selection_container.dart

Lines 203 to 204 in 7482962

@override

List<Rect> get boundingBoxes => <Rect>[(context.findRenderObject()! as RenderBox).paintBounds];

.

Adding onto my last comment, a placeholder is only guaranteed to have one item in their boundingBoxes list if it is a SelectionContainer which is only guaranteed when the placeholder is a Text widget itself.

justinmc · 2024-03-05T21:33:21Z

I just tried doing some QA work here. This one seems to be a bug:

Screencast.from.2024-03-05.13-24-04.webm

Code

const SelectionArea(
  child: Text.rich(
    WidgetSpan(
      child: Column(
        children: <Widget>[
          Text('I am a Text widget.'),
          Text('I am a Text widget.'),
          Text('I am a Text widget.'),
          Text('I am a Text widget.'),
          Text('I am a Text widget.'),
          Text('I am a Text widget.'),
          Text('I am a Text widget.'),
          Text('I am a Text widget.'),
        ],
      ),
    ),
  ),
),

And this one is a subtle difference between the native behavior on Linux as an FYI, but I think it's probably not worth fixing. It looks like this PR behaves correctly like Mac does natively, and that behavior seems more intuitive to me IMO.

Screencast.from.2024-03-05.13-22-10.webm

Code

const SelectionArea(
  child: Text.rich(
    TextSpan(text: 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaafaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'),
  ),
),

Renzo-Olivares · 2024-03-14T19:56:28Z

This is ready for another review. It fixes the case pointed out here #144563 (comment) . Regarding the linux behavior, I'll make a follow up PR for that.

justinmc

I'm still trying to break your PR in QA but the code is looking good.

I confirmed that my previous bug is fixed, thank you! I think this might be a bug when I triple click and drag into the long line at the top in this video. Notice how, especially towards the end of the video, the selection flashes and I'm sometimes able to get the selection to not span the whole line. Maybe it's just a weird case with what I'm doing...

Screencast.from.2024-03-18.14-47-16.webm

This one is probably unrelated to your PR, but notice how triple clicking to the side of the text on the short lines doesn't select the line, but on native it does:

Native Linux TextEdit	Flutter
Screencast.from.2024-03-18.14-45-35.webm	Screencast.from.2024-03-18.14-43-47.webm

Code in both cases

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatelessWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  final String title;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: const <Widget>[
            SelectionArea(
              child: Text.rich(
                WidgetSpan(
                  child: Column(
                    children: <Widget>[
                      Text('Text widget.I am a Text widget.I am a Text widget.I am a Text widget.I am a Text widget.I am a Text widget.I am a Text widget.I am a Text widget. Text widget.I am a Text widget.I am a Text widget.I am a Text widget.I am a Text widget.I am a Text widget.I am a Text widget.I am a Text widget.'),
                      Text('I am a Text widget.'),
                      Text('I am a Text widget.'),
                      Text('I am a Text widget.'),
                      Text('I am a Text widget.'),
                      Text('I am a Text widget.'),
                      Text('I am a Text widget.'),
                      Text('I am a Text widget.'),
                      Text('I am a Text widget.'),
                    ],
                  ),
                ),
              ),
            ),
          ],
        ),
      ),
    );
  }
}

packages/flutter/test/widgets/selectable_region_test.dart

justinmc · 2024-03-18T22:05:15Z

packages/flutter/lib/src/widgets/text.dart

+  }
+}
+
+class _SelectableTextContainer extends StatefulWidget {


Nit: This makes me think of SelectableText the widget, should it be renamed? No worries if you disagree, "selectable text" is a pretty generic term, it's fine either way.

We might want to move this out of here eventually, and put it with SelectableText. But I think its fine for now since its private. Something to think about for later might be whether we want Text to be completely un-selectable in all cases even when under a SelectionArea, and then SelectableText will be the text component that is selectable. Having them both selectable, makes me wonder why they both should exist besides historical reasons/breaking changes.

Not to start an unrelated naming debate in this comment thread, but I worry about the existing problem where users (especially on the web) use Text widgets expecting them to be selectable when they're not... Not sure exactly how we should organize/name this though. I agree this PR is fine as-is since it's private.

If we do keep both Text and SelectableText though, it would be cool to implement SelectableText simply as a wrapper of Text and SelectionArea.

I think that's still the plan for SelectableText with #104547 (Using Text and SelectionArea). I think at that time we should evaluate whether we should move this _SelectableTextContainer to SelectableText. I agree though it is a bit confusing for someone that is going to dig into this code.

packages/flutter/lib/src/widgets/text.dart

packages/flutter/lib/src/rendering/paragraph.dart

Renzo-Olivares · 2024-03-19T20:06:08Z

@justinmc Thanks for the review! The first bug you pointed out looks like i'm not handling some edge case. I'll check it out, as well as the second bug!

Renzo-Olivares · 2024-03-21T19:25:47Z

@justinmc #144563 (review) the first issue you described is now fixed. The second issue doesn't seem related to this PR so i'll make an issue and look into it more later.

Most of the failing tests are a result of the this commit b8d118e. I'm still investigating why this is the case.

Renzo-Olivares · 2024-03-22T19:31:17Z

I looked into the broken tests caused by b8d118e, they turned out being expected since the test checks the widget tree structure, and the _RichText wrapper changes the structure. For now I decided to use the _RichText wrapper conditionally since it was also breaking customer tests.

flutter/packages/flutter_driver/test/src/real_tests/extension_test.dart

Line 832 in 7009b92

testWidgets('GetDiagnosticsTree', (WidgetTester tester) async {

justinmc

LGTM with nits 👍

I tried QA'ing this again and I thought I had found a bug similar to the flashy one I mentioned last time, then I realized I hadn't pulled your latest changes 😀 . After I did that it seems rock solid. No flashiness or partial selection like I saw before at all, seems to work great.

packages/flutter/lib/src/widgets/selectable_region.dart

justinmc · 2024-03-28T18:04:07Z

packages/flutter/lib/src/widgets/text.dart

+  }
+}
+
+class _SelectableTextContainer extends StatefulWidget {


Not to start an unrelated naming debate in this comment thread, but I worry about the existing problem where users (especially on the web) use Text widgets expecting them to be selectable when they're not... Not sure exactly how we should organize/name this though. I agree this PR is fine as-is since it's private.

If we do keep both Text and SelectableText though, it would be cool to implement SelectableText simply as a wrapper of Text and SelectionArea.

justinmc · 2024-03-28T18:32:50Z

packages/flutter/lib/src/widgets/text.dart

+  @override
+  Comparator<Selectable> get compareOrder => _compareScreenOrder;
+
+  int _compareScreenOrder(Selectable a, Selectable b) {


Could this also be static?

Also, how is it that we didn't have logic like this up until this PR? Is there any place to share this logic, especially since it's pretty isolated in static methods?

Anyway, thanks for putting in all of the effort required to get this to work. I think it's not clearly evident that something that sounds simple like adding triple tap support involves bringing all of this massive selection infrastructure to Text as well.

It can be static. If you are referring to _adjustSelection and _initSelection, I am using different implementations compared to the one in the base class

flutter/packages/flutter/lib/src/widgets/selectable_region.dart

Line 1720 in 9d6b4f1

abstract class MultiSelectableSelectionContainerDelegate extends SelectionContainerDelegate with ChangeNotifier {

. Regarding the compare* methods those are also slightly different besides the horizontal and vertical comparison. Also anything below // From [SelectableRegion]. comes from

flutter/packages/flutter/lib/src/widgets/selectable_region.dart

Line 1560 in 9d6b4f1

class _SelectableRegionContainerDelegate extends MultiSelectableSelectionContainerDelegate {

. I'll evaluate how much of this code we can expose to make the code more shareable in a follow up PR.

justinmc · 2024-03-28T18:40:34Z

packages/flutter/test/widgets/scrollable_selection_test.dart

+    final RenderParagraph paragraph2 = tester.renderObject<RenderParagraph>(find.descendant(of: find.text('Item 1'), matching: find.byType(RichText)));
+    expect(paragraph2.selections.isEmpty, isTrue);
+    await gesture.moveTo(textOffsetToPosition(paragraph2, 5) + const Offset(0, 50));
+    // Should select paragraph 2.


So even though these paragraphs might be in the same horizontal row, triple tap drag still selects them one by one. Tricky but I think that's correct 👍

packages/flutter/test/widgets/selectable_region_test.dart

packages/flutter/lib/src/widgets/selectable_region.dart

justinmc

Renewing my LGTM after the recent changes, thanks!

This reverts commit ea37f5cb01c670b6edbfd2b52003338c66ca98ed.

auto-submit · 2024-03-29T22:36:52Z

auto label is removed for flutter/flutter/144563, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

justinmc

LGTM 👍

Would it be possible to add a test where this kind of bug can be caught in a more straightforward way than the obscure image diff tests?

packages/flutter/lib/src/widgets/text.dart

This reverts commit f1e32aa.

…r#144563)

Roll Flutter from a418568 to e868e2b (34 revisions) flutter/flutter@a418568...e868e2b 2024-04-03 [email protected] Add SegmentedButton expand feature (flutter/flutter#142804) 2024-04-03 [email protected] Roll Flutter Engine from e36b9b10c36f to 56fa2c33a5f7 (1 revision) (flutter/flutter#146205) 2024-04-03 [email protected] Roll Packages from 83f3842 to 0e848fa (3 revisions) (flutter/flutter#146201) 2024-04-03 [email protected] Enhance ColorScheme.fromSeed with a new `variant` parameter (flutter/flutter#144805) 2024-04-03 [email protected] Roll Flutter Engine from 0280de5be276 to e36b9b10c36f (1 revision) (flutter/flutter#146200) 2024-04-03 [email protected] Fix typos in bottom_sheet.dart (flutter/flutter#146188) 2024-04-03 [email protected] Roll Flutter Engine from 979030d81f8d to 0280de5be276 (2 revisions) (flutter/flutter#146199) 2024-04-03 [email protected] Roll Flutter Engine from bef3bbe3f74e to 979030d81f8d (1 revision) (flutter/flutter#146186) 2024-04-03 [email protected] Roll Flutter Engine from 5fc83bc24b2e to bef3bbe3f74e (1 revision) (flutter/flutter#146183) 2024-04-03 [email protected] Roll Flutter Engine from 0da1b2eb370a to 5fc83bc24b2e (1 revision) (flutter/flutter#146180) 2024-04-03 [email protected] Avoid calling `TextPainter.plainText` for simple static text (flutter/flutter#146084) 2024-04-03 [email protected] Roll Flutter Engine from e603f89844a9 to 0da1b2eb370a (2 revisions) (flutter/flutter#146179) 2024-04-03 [email protected] Roll Flutter Engine from ef60a95d78c1 to e603f89844a9 (3 revisions) (flutter/flutter#146177) 2024-04-03 [email protected] Fix chip baseline implementation (flutter/flutter#146162) 2024-04-03 [email protected] Roll Flutter Engine from bb4ec2d7eb39 to ef60a95d78c1 (1 revision) (flutter/flutter#146176) 2024-04-03 [email protected] Add tests for material_state_mouse_cursor.0.dart API example. (flutter/flutter#145987) 2024-04-03 [email protected] Update material_color_utilities package version to latest 0.11.1 (flutter/flutter#145959) 2024-04-03 [email protected] Roll Flutter Engine from 5f6dec8bd877 to bb4ec2d7eb39 (4 revisions) (flutter/flutter#146169) 2024-04-03 [email protected] Roll Flutter Engine from 5dbcfdc2a456 to 5f6dec8bd877 (1 revision) (flutter/flutter#146163) 2024-04-02 [email protected] Dispose FocusNode in tests. (flutter/flutter#146161) 2024-04-02 [email protected] Add `none` language strings to code blocks. (flutter/flutter#146154) 2024-04-02 [email protected] Refactor docs (flutter/flutter#145998) 2024-04-02 [email protected] Roll Flutter Engine from c60b00a20fc3 to 5dbcfdc2a456 (3 revisions) (flutter/flutter#146159) 2024-04-02 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller__timeline_summary to be unflaky (flutter/flutter#140038) 2024-04-02 [email protected] Roll Flutter Engine from 5bf8b94505a4 to c60b00a20fc3 (2 revisions) (flutter/flutter#146157) 2024-04-02 [email protected] Refactor analyze (flutter/flutter#146138) 2024-04-02 [email protected] Implement SelectionArea triple click gestures (flutter/flutter#144563) 2024-04-02 [email protected] Roll Flutter Engine from 6883f7313da0 to 5bf8b94505a4 (2 revisions) (flutter/flutter#146152) 2024-04-02 [email protected] Fix border color is wrong for a focused and hovered TextField (flutter/flutter#146127) 2024-04-02 [email protected] Sync lints and enable `annotate_redeclares` (flutter/flutter#146144) 2024-04-02 [email protected] Implements `RenderBox.computeDryBaseline` for material render boxes (flutter/flutter#146027) 2024-04-02 [email protected] Roll Flutter Engine from 523fc953ebc8 to 6883f7313da0 (2 revisions) (flutter/flutter#146140) 2024-04-02 [email protected] Fix `MenuItemButton` overflow (flutter/flutter#143932) 2024-04-02 [email protected] Roll Packages from d5aff19 to 83f3842 (4 revisions) (flutter/flutter#146134) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

Renzo-Olivares requested review from justinmc and LongCatIsLooong March 4, 2024 21:22

justinmc reviewed Mar 4, 2024

View reviewed changes

Renzo-Olivares force-pushed the sa-multiselectable-boundary-paragraph branch 2 times, most recently from c227d3f to 29e71b4 Compare March 14, 2024 18:29

Renzo-Olivares requested a review from justinmc March 14, 2024 19:52

justinmc reviewed Mar 18, 2024

View reviewed changes

Renzo-Olivares force-pushed the sa-multiselectable-boundary-paragraph branch from 62461ba to 3f83bea Compare March 21, 2024 18:53

Renzo-Olivares requested a review from justinmc March 22, 2024 19:27

Renzo-Olivares force-pushed the sa-multiselectable-boundary-paragraph branch from 5d546fa to 2af554a Compare March 26, 2024 11:27

Renzo-Olivares mentioned this pull request Mar 26, 2024

SelectionArea supported gestures should have feature parity with TextSelectionGestureDetector #129583

Open

justinmc approved these changes Mar 28, 2024

View reviewed changes

justinmc approved these changes Mar 29, 2024

View reviewed changes

Renzo-Olivares added 7 commits March 29, 2024 12:36

implement triple click and triple click drag

5568874

add comments

4289390

Dont split text into fragments

2901d9a

make Text widget a SelectionContainer

6970c3d

updates

8107227

Revert "Dont split text into fragments"

ff61432

This reverts commit ea37f5cb01c670b6edbfd2b52003338c66ca98ed.

modify paragraph search logic to consider entire text

f790602

Renzo-Olivares added 6 commits March 29, 2024 12:36

get rid of some nesting

cccd2f2

fix analyzer

f5bf40c

address reviewer comments

b4fd3f5

address reviewer comments

b208202

address reviewer comments

260ebf5

Address reviewer comments

4f0c7a2

Renzo-Olivares force-pushed the sa-multiselectable-boundary-paragraph branch from 62b593e to 4f0c7a2 Compare March 29, 2024 19:36

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2024

Should not create GlobalKey in build method

ec4871c

Renzo-Olivares requested a review from justinmc April 1, 2024 21:29

justinmc approved these changes Apr 1, 2024

View reviewed changes

packages/flutter/lib/src/widgets/text.dart Show resolved Hide resolved

packages/flutter/lib/src/widgets/text.dart Show resolved Hide resolved

Add test for GlobalKey changes

f1e32aa

Renzo-Olivares requested a review from justinmc April 1, 2024 23:00

Revert "Add test for GlobalKey changes"

6c137fc

This reverts commit f1e32aa.

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2024

auto-submit bot merged commit 2a37c6f into flutter:master Apr 2, 2024
67 checks passed

polina-c mentioned this pull request Apr 2, 2024

Dispose FocusNode in tests. #146161

Merged

engine-flutter-autoroll mentioned this pull request Apr 3, 2024

Roll Flutter from a418568a6498 to bd4c17155d02 (28 revisions) flutter/packages#6452

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024

2a37c6f Implement SelectionArea triple click gestures (flutter/flutte…

172eb42

…r#144563)

engine-flutter-autoroll mentioned this pull request Apr 3, 2024

Roll Flutter from a418568a6498 to 1326c8ee536e (29 revisions) flutter/packages#6454

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024

2a37c6f Implement SelectionArea triple click gestures (flutter/flutte…

fef2219

…r#144563)

engine-flutter-autoroll mentioned this pull request Apr 3, 2024

Roll Flutter from a418568a6498 to e868e2b3834f (34 revisions) flutter/packages#6455

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024

2a37c6f Implement SelectionArea triple click gestures (flutter/flutte…

623354c

…r#144563)

HansMuller mentioned this pull request Apr 5, 2024

Flutter Framework Team: Notable Commits #121415

Open

huycozy mentioned this pull request Jun 18, 2024

SelectionArea deselects other widgets on right click #150268

Closed

	@override
	List<Rect> get boundingBoxes => <Rect>[(context.findRenderObject()! as RenderBox).paintBounds];

Implement SelectionArea triple click gestures #144563

Implement SelectionArea triple click gestures #144563

Conversation

Renzo-Olivares commented Mar 4, 2024 • edited Loading

Pre-launch Checklist

justinmc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares Mar 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares Mar 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares Mar 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinmc commented Mar 5, 2024

Renzo-Olivares commented Mar 14, 2024

justinmc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Renzo-Olivares commented Mar 19, 2024

Renzo-Olivares commented Mar 21, 2024

Renzo-Olivares commented Mar 22, 2024 • edited Loading

justinmc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

justinmc left a comment

Choose a reason for hiding this comment

auto-submit bot commented Mar 29, 2024

justinmc left a comment

Choose a reason for hiding this comment

Renzo-Olivares commented Mar 4, 2024 •

edited

Loading

Renzo-Olivares Mar 26, 2024 •

edited

Loading

Renzo-Olivares Mar 5, 2024 •

edited

Loading

Renzo-Olivares Mar 5, 2024 •

edited

Loading

Renzo-Olivares commented Mar 22, 2024 •

edited

Loading