add more print traces in hot runner workflow #148258

andrewkolos · 2024-05-13T21:27:01Z

In service of #146879. See #146879 (comment) in particular for the purpose of this PR. This adds a few more printTrace calls to try to see where we are getting stuck.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

jonahwilliams

LGTM!

christopherfujino

ship it

…#148258)

flutter/flutter@1255435...d2da1b2 2024-05-14 [email protected] Roll Flutter Engine from 491f460a25fb to 7bf865774d06 (1 revision) (flutter/flutter#148325) 2024-05-14 [email protected] Roll Packages from 1412041 to fd714bd (1 revision) (flutter/flutter#148324) 2024-05-14 [email protected] Roll Flutter Engine from c381b852605f to 491f460a25fb (1 revision) (flutter/flutter#148319) 2024-05-14 [email protected] Roll Flutter Engine from b4b798d2e706 to c381b852605f (1 revision) (flutter/flutter#148303) 2024-05-14 [email protected] Roll Flutter Engine from 0de6701b537a to b4b798d2e706 (2 revisions) (flutter/flutter#148299) 2024-05-14 [email protected] Roll Flutter Engine from 764c33c3c773 to 0de6701b537a (2 revisions) (flutter/flutter#148297) 2024-05-14 [email protected] Roll Flutter Engine from 797eab742925 to 764c33c3c773 (1 revision) (flutter/flutter#148290) 2024-05-14 [email protected] Roll Flutter Engine from 84687fe0f199 to 797eab742925 (1 revision) (flutter/flutter#148288) 2024-05-14 [email protected] Roll Flutter Engine from bee398d95abe to 84687fe0f199 (3 revisions) (flutter/flutter#148282) 2024-05-14 [email protected] Roll Flutter Engine from a1cdcb6a6687 to bee398d95abe (2 revisions) (flutter/flutter#148280) 2024-05-14 [email protected] Roll Flutter Engine from 13a561cb6d5a to a1cdcb6a6687 (1 revision) (flutter/flutter#148276) 2024-05-14 [email protected] Roll Flutter Engine from 7dcbd93e5c1a to 13a561cb6d5a (6 revisions) (flutter/flutter#148274) 2024-05-13 [email protected] Roll Flutter Engine from aeff9b174c84 to 7dcbd93e5c1a (1 revision) (flutter/flutter#148266) 2024-05-13 [email protected] Mark platform_views_scroll_perf_ad_banners__timeline_summary not flaky (flutter/flutter#148263) 2024-05-13 [email protected] add more print traces in hot runner workflow (flutter/flutter#148258) 2024-05-13 [email protected] Refactors page API (flutter/flutter#137792) 2024-05-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.3 to 3.25.5 (flutter/flutter#148262) 2024-05-13 [email protected] Roll Flutter Engine from 11502404a52a to aeff9b174c84 (2 revisions) (flutter/flutter#148260) 2024-05-13 [email protected] Use super.key instead of manually passing the Key parameter to the parent class (flutter/flutter#147621) 2024-05-13 [email protected] Try fix module test (flutter/flutter#147934) 2024-05-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Native ios context menu (#143002) (#148238)" (flutter/flutter#148254) 2024-05-13 [email protected] Reland Native ios context menu (#143002) (flutter/flutter#148238) 2024-05-13 [email protected] Roll Flutter Engine from 636374fd00ee to 11502404a52a (1 revision) (flutter/flutter#148242) 2024-05-13 [email protected] Roll Packages from 6c4482a to 1412041 (16 revisions) (flutter/flutter#148239) 2024-05-13 [email protected] Roll Flutter Engine from 0050bf9a8094 to 636374fd00ee (1 revision) (flutter/flutter#148216) 2024-05-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Native ios context menu (#143002)" (flutter/flutter#148237) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…#148258)

add more print traces in hot runner workflow

78333e4

andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label May 13, 2024

andrewkolos requested a review from jonahwilliams May 13, 2024 21:29

DI logger to make tests work

be3a6be

andrewkolos marked this pull request as ready for review May 13, 2024 21:57

andrewkolos requested a review from christopherfujino May 13, 2024 22:01

jonahwilliams approved these changes May 13, 2024

View reviewed changes

andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2024

christopherfujino approved these changes May 13, 2024

View reviewed changes

auto-submit bot merged commit 7d26350 into flutter:master May 13, 2024
129 checks passed

engine-flutter-autoroll mentioned this pull request May 14, 2024

Roll Flutter from 125543505d26 to cb656c21f082 (23 revisions) flutter/packages#6726

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

7d26350 add more print traces in hot runner workflow (flutter/flutter…

c683021

…#148258)

engine-flutter-autoroll mentioned this pull request May 14, 2024

Roll Flutter from 125543505d26 to a39555d4fe89 (24 revisions) flutter/packages#6728

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

7d26350 add more print traces in hot runner workflow (flutter/flutter…

4c9f5c8

…#148258)

engine-flutter-autoroll mentioned this pull request May 14, 2024

Roll Flutter from 125543505d26 to d2da1b280b51 (26 revisions) flutter/packages#6729

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

7d26350 add more print traces in hot runner workflow (flutter/flutter…

131b82f

…#148258)

andrewkolos mentioned this pull request Jun 5, 2024

[flutter_tools] Remove additional listener on VM service that simply logged incoming messages #149756

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

7d26350 add more print traces in hot runner workflow (flutter/flutter…

24eff9f

…#148258)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add more print traces in hot runner workflow #148258

add more print traces in hot runner workflow #148258

andrewkolos commented May 13, 2024

jonahwilliams left a comment

christopherfujino left a comment

add more print traces in hot runner workflow #148258

add more print traces in hot runner workflow #148258

Conversation

andrewkolos commented May 13, 2024

Pre-launch Checklist

jonahwilliams left a comment

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment