Remove `dual_screen` from `new_gallery` integration test #150808

gmackall · 2024-06-25T22:38:31Z

Removes the dual_screen package from new_gallery. Unblocks the fourth attempt to land flutter/engine#53001.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jonahwilliams

LGTM

gmackall · 2024-06-26T17:43:36Z

Looks like we can't force the tests to run in pre-submit, ex:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux_mokey%20new_gallery_impeller__transition_perf/1/overview

This reverts commit f5b8897.

christopherfujino

looks really good to me

gmackall · 2024-06-26T19:45:00Z

Reason for revert: Causing the new_gallery tests to hang.

I can repro now though, so should be able to find a fix shortly. I'll get all the tests passing on my device before putting up a reland

…0808)" This reverts commit 1d13676.

…50808)" (#150871) Reverts: #150808 Initiated by: gmackall Reason for reverting: Causing the new_gallery tests to hang. I can repro now though, so should be able to find a fix shortly Original PR Author: gmackall Reviewed By: {christopherfujino, johnmccutchan, jtmcdole, jonahwilliams} This change reverts the following previous change: Removes the `dual_screen` package from `new_gallery`. Unblocks the fourth attempt to land flutter/engine#53001.

gmackall · 2024-06-26T19:58:24Z

dev/integration_tests/new_gallery/lib/pages/home.dart

@@ -1166,47 +1164,8 @@ class _StudyWrapperState extends State<StudyWrapper> {
              child: widget.study,
            ),
          ),
-          if (!isDisplayFoldable(context))


This is almost certainly the mistake - given that the conditional is !isDisplayFoldable(context) I shouldn't have deleted the contents, but rather left them around. Will test and put up a new pr if that's correct

…test (flutter#150808)" (flutter#150871)" This reverts commit 43a8b6a.

Relands #150808 The original version of the pr [accidentally deleted the back button](#150808 (comment)), which didn't block the app building but made the test hang because it couldn't back out of the demo pages. Repro-ed the failure, and then tested that ``` new_gallery_opengles_impeller__transition_perf new_gallery__transition_perf new_gallery_impeller_old_zoom__transition_perf new_gallery__crane_perf new_gallery_impeller__transition_perf ``` All pass on my pixel 7 pro, with ` dart bin/test_runner.dart test -t <test>`, after re-adding the mistakenly deleted content. Did not test on an iOS device (I don't have one), but those tests were failing for the same reason from what I can tell: ``` > reply@study [2024-06-26 12:49:21.884543] [STDOUT] stdout: [ ] scrolling to demo [2024-06-26 12:49:22.412479] [STDOUT] stdout: [ +527 ms] tapping demo [2024-06-26 12:49:28.075978] [STDOUT] stderr: [+5663 ms] VMServiceFlutterDriver: tap message is taking a long time to complete... ``` Which is the same error, and which makes sense - they got stuck because they couldn't back out of the page. Sorry for the churn ð��

…tter/flutter#150808)

Manual roll Flutter from e726eb4 to 15f95ce (48 revisions) Manual roll requested by [email protected] flutter/flutter@e726eb4...15f95ce 2024-06-28 [email protected] Roll Flutter Engine from ddd4814b9d40 to 94591ffb20df (5 revisions) (flutter/flutter#150968) 2024-06-27 [email protected] Manual engine roll to ddd4814 (flutter/flutter#150952) 2024-06-27 [email protected] local lint copy gradle task config (flutter/flutter#150957) 2024-06-27 [email protected] Roll Flutter Engine from b42c80460538 to d1506c12808e (3 revisions) (flutter/flutter#150951) 2024-06-27 [email protected] [tool] make the `systemTempDirectory` getter on `ErrorHandlingFileSystem` wrap the underlying filesystem's temp directory in a`ErrorHandlingDirectory` (flutter/flutter#150876) 2024-06-27 [email protected] Have flutter.js load local canvaskit instead of the CDN when appropriate (flutter/flutter#150806) 2024-06-27 [email protected] Roll Flutter Engine from a9194f0f01f4 to b42c80460538 (10 revisions) (flutter/flutter#150940) 2024-06-27 [email protected] [a11y] Reland [#149375 ] Update semantics in dropdown.dart (flutter/flutter#150578) 2024-06-27 [email protected] Bump dartdoc to 8.0.9+1 (flutter/flutter#150935) 2024-06-27 [email protected] add onFocus to text fields (flutter/flutter#150648) 2024-06-27 [email protected] Fixes `flutter build ipa` failure: Command line name "app-store" is deprecated. Use "app-store-connect" (flutter/flutter#150407) 2024-06-27 [email protected] Copy any previous `IconThemeData` instead of overwriting it in CupertinoButton (flutter/flutter#149777) 2024-06-27 [email protected] Improve the behavior of scrollbar drag-scrolls triggered by the trackpad (flutter/flutter#150275) 2024-06-27 [email protected] feat: Add autofocus for `MenuItemButton` (flutter/flutter#139396) 2024-06-27 [email protected] Roll Flutter Engine from 1d5e3cc55a75 to a9194f0f01f4 (7 revisions) (flutter/flutter#150888) 2024-06-26 [email protected] Reland "Remove dual_screen from new_gallery integration test" (flutter/flutter#150873) 2024-06-26 [email protected] Switch to more reliable flutter.dev link destinations in the tool (flutter/flutter#150587) 2024-06-26 [email protected] Adding `@docImport`s to the `animation` library (flutter/flutter#150798) 2024-06-26 [email protected] Remove CODEOWNERS trailing whitespace (flutter/flutter#150882) 2024-06-26 [email protected] Roll Flutter Engine from e03cf86c4170 to 1d5e3cc55a75 (3 revisions) (flutter/flutter#150875) 2024-06-26 [email protected] Remind folks we are moving. (flutter/flutter#150872) 2024-06-26 [email protected] Remove `bringup: true` from web test shard. (flutter/flutter#150785) 2024-06-26 [email protected] Roll Flutter Engine from c0017bed42c2 to e03cf86c4170 (1 revision) (flutter/flutter#150867) 2024-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `dual_screen` from `new_gallery` integration test (#150808)" (flutter/flutter#150871) 2024-06-26 [email protected] Remove `dual_screen` from `new_gallery` integration test (flutter/flutter#150808) 2024-06-26 [email protected] Roll Flutter Engine from d4624a36712b to c0017bed42c2 (4 revisions) (flutter/flutter#150865) 2024-06-26 [email protected] Fixes for Style Guide for Flutter Repo (flutter/flutter#150167) 2024-06-26 [email protected] Roll Flutter Engine from da62c629ed5c to d4624a36712b (3 revisions) (flutter/flutter#150852) 2024-06-26 [email protected] Use `Isolate.packageConfigSync! to locate the packageconfig of flutter tools (flutter/flutter#150340) 2024-06-26 [email protected] Roll Flutter Engine from 25af762ffbb3 to da62c629ed5c (2 revisions) (flutter/flutter#150829) 2024-06-26 [email protected] Fix leaky tests. (flutter/flutter#150817) 2024-06-26 [email protected] Roll Flutter Engine from 94023d711db3 to 25af762ffbb3 (4 revisions) (flutter/flutter#150818) 2024-06-26 [email protected] Roll pub packages (flutter/flutter#150810) 2024-06-25 [email protected] Remove reference to `MaterialApp` and `showCupertinoModalPopup` from `CupertinoAlertDialog` (flutter/flutter#150725) 2024-06-25 [email protected] Read `AndroidManifest.xml` and emit `manifest-impeller-(enabled|disabled)` analytics (flutter/flutter#150791) 2024-06-25 [email protected] [flutter_tools] Shut down Chromium cleanly using a command sent through the debug protocol (flutter/flutter#150645) 2024-06-25 [email protected] Reland fix inputDecorator hint color on M3 (flutter/flutter#150278) 2024-06-25 [email protected] Roll Flutter Engine from 62e0b5f9c340 to 94023d711db3 (7 revisions) (flutter/flutter#150797) 2024-06-25 [email protected] Fix collapsed InputDecorator minimum height (flutter/flutter#150770) 2024-06-25 [email protected] Add more warm up frame docs (flutter/flutter#150464) 2024-06-25 [email protected] Roll pub packages (flutter/flutter#150739) 2024-06-25 [email protected] Add `focusNode`, `focusColor`, `onFocusChange`, `autofocus` to `CupertinoButton` (flutter/flutter#150721) 2024-06-25 [email protected] Document RenderObject._relayoutBoundary and its invariant; small refactors (flutter/flutter#150527) 2024-06-25 [email protected] Roll Flutter Engine from 6313b1e5afd7 to 62e0b5f9c340 (1 revision) (flutter/flutter#150790) ...

…tter/flutter#150808)

entirely remove dual_screen from new_gallery

fde8aa0

github-actions bot added the f: routes Navigator, Router, and related APIs. label Jun 25, 2024

update-packages output

502793d

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 25, 2024

gmackall marked this pull request as ready for review June 26, 2024 14:56

gmackall requested a review from christopherfujino as a code owner June 26, 2024 14:56

gmackall requested review from jonahwilliams and a team June 26, 2024 14:56

jonahwilliams approved these changes Jun 26, 2024

View reviewed changes

jtmcdole approved these changes Jun 26, 2024

View reviewed changes

johnmccutchan approved these changes Jun 26, 2024

View reviewed changes

try faking presubmit runs

f5b8897

Revert "try faking presubmit runs"

fa342eb

This reverts commit f5b8897.

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2024

christopherfujino approved these changes Jun 26, 2024

View reviewed changes

gmackall added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jun 26, 2024

auto-submit bot merged commit 1d13676 into flutter:master Jun 26, 2024
138 checks passed

gmackall added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 26, 2024

auto-submit bot pushed a commit that referenced this pull request Jun 26, 2024

Revert "Remove dual_screen from new_gallery integration test (#15…

4d6bbe2

…0808)" This reverts commit 1d13676.

auto-submit bot mentioned this pull request Jun 26, 2024

Reverts "Remove dual_screen from new_gallery integration test (#150808)" #150871

Merged

9 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jun 26, 2024

gmackall commented Jun 26, 2024

View reviewed changes

gmackall pushed a commit to gmackall/flutter that referenced this pull request Jun 26, 2024

Revert "Reverts "Remove dual_screen from new_gallery integration …

081e0c0

…test (flutter#150808)" (flutter#150871)" This reverts commit 43a8b6a.

gmackall mentioned this pull request Jun 26, 2024

Reland "Remove dual_screen from new_gallery integration test" #150873

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ef34436402be (39 revisions) flutter/packages#6996

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

74ed6d9

…tter/flutter#150808)

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ba03c59406c7 (40 revisions) flutter/packages#6999

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

6dc3b58

…tter/flutter#150808)

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ab4d42221349 (42 revisions) flutter/packages#7000

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

9a6af3c

…tter/flutter#150808)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Manual roll Flutter from e726eb401c2c to 15f95ce0c38e (48 revisions) flutter/packages#7002

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

78c227a

…tter/flutter#150808)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to eb58fe16b60f (50 revisions) flutter/packages#7005

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

6a2f82a

…tter/flutter#150808)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to 9e1efd8bcce7 (51 revisions) flutter/packages#7006

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

956dceb

…tter/flutter#150808)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to 47e65e806f75 (52 revisions) flutter/packages#7007

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

08360a8

…tter/flutter#150808)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to 3a97a38c41f1 (53 revisions) flutter/packages#7008

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

18e5664

…tter/flutter#150808)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to f5b671aac723 (54 revisions) flutter/packages#7009

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

bff4f4c

…tter/flutter#150808)

reidbaker mentioned this pull request Jul 1, 2024

Not possible to run some android tests in presubmit even when modifying ci.yaml #151114

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

1d13676 Remove dual_screen from new_gallery integration test (flu…

e8f63e3

…tter/flutter#150808)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `dual_screen` from `new_gallery` integration test #150808

Remove `dual_screen` from `new_gallery` integration test #150808

gmackall commented Jun 25, 2024 •

edited

Loading

jonahwilliams left a comment

gmackall commented Jun 26, 2024 •

edited

Loading

christopherfujino left a comment

gmackall commented Jun 26, 2024 •

edited

Loading

gmackall Jun 26, 2024

Remove dual_screen from new_gallery integration test #150808

Remove dual_screen from new_gallery integration test #150808

Conversation

gmackall commented Jun 25, 2024 • edited Loading

Pre-launch Checklist

jonahwilliams left a comment

Choose a reason for hiding this comment

gmackall commented Jun 26, 2024 • edited Loading

christopherfujino left a comment

Choose a reason for hiding this comment

gmackall commented Jun 26, 2024 • edited Loading

gmackall Jun 26, 2024

Choose a reason for hiding this comment

Remove `dual_screen` from `new_gallery` integration test #150808

Remove `dual_screen` from `new_gallery` integration test #150808

gmackall commented Jun 25, 2024 •

edited

Loading

gmackall commented Jun 26, 2024 •

edited

Loading

gmackall commented Jun 26, 2024 •

edited

Loading