[H] Fix bugs in RenderSizedOverflowBox and RenderFractionallySizedOverflowBox #23492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @goderbauer |
Hixie
changed the title
Hixie
changed the title
goderbauer
approved these changes
Oct 25, 2018
| class RenderFractionallySizedOverflowBox extends RenderAligningShiftedBox { | ||
| /// Creates a render box that sizes its child to a fraction of the total available space. | ||
| /// | ||
| /// If non-null, the [widthFactor] and [heightFactor] arguments must be | ||
| /// non-negative. | ||
| /// | ||
| /// The [alignment] must be null. |
There was a problem hiding this comment.
Why do we even have the alignment leaver then? :)
Joke aside: there's a "not" missing here.
…wBox Bug #1: These didn't work with directional alignments, due to an error in the types of the constructor arguments. Bug #2: Pretty sure RenderSizedOverflowBox never worked at all. As soon as I wrote a test for it, the test showed that there was a fundamental bug in its performLayout method: it didn't set parentUsesSize, but it immediately tried to use the child's size.
Hixie
force-pushed
the
FractionallySizedBox
branch
from
b379d08
to
5496a98
Compare
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
…wBox (flutter#23492) Bug flutter#1: These didn't work with directional alignments, due to an error in the types of the constructor arguments. Bug flutter#2: Pretty sure RenderSizedOverflowBox never worked at all. As soon as I wrote a test for it, the test showed that there was a fundamental bug in its performLayout method: it didn't set parentUsesSize, but it immediately tried to use the child's size.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #1: These didn't work with directional alignments, due to an error
in the types of the constructor arguments.
Bug #2: Pretty sure RenderSizedOverflowBox never worked at all. As
soon as I wrote a test for it, the test showed that there was a
fundamental bug in its performLayout method: it didn't set
parentUsesSize, but it immediately tried to use the child's size.