Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start reporting isolate life cycle events #5312

Closed
wants to merge 1 commit into from
Closed

Start reporting isolate life cycle events #5312

wants to merge 1 commit into from

Conversation

johnmccutchan
Copy link
Contributor

  • Add IsolateTracker.
  • Tell the IsolateTracker what the view's isolate id is.
  • Start printing important isolate life cycle events.

@johnmccutchan
Copy link
Contributor Author

@devoncarew

devoncarew
devoncarew reviewed Aug 9, 2016
View reviewed changes
packages/flutter_tools/lib/src/isolate_tracker.dart
String _viewIsolateId;
set viewIsolateId(String viewIsolateId) {
_viewIsolateId = viewIsolateId;
printStatus('View is now controlled by isolate $_viewIsolateId');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

printTrace?

@devoncarew
Copy link
Member

lgtm, w/ some questions

@eseidelGoogle
Copy link
Contributor

Looking through old PRs, found this one. Curious of the status?

@johnmccutchan
Copy link
Contributor Author

@eseidelGoogle This is on hold until I lay some more foundation work

@Hixie
Copy link
Contributor

Hixie commented Aug 26, 2016

@johnmccutchan Since you're not going to be working on this for a few days I'm going to close the PR for now so that it isn't in our review queue. Please don't hesitate to reopen it when you're ready for review.

@Hixie Hixie closed this Aug 26, 2016
@johnmccutchan johnmccutchan deleted the isolate_tracker branch November 22, 2016 00:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnmccutchan @devoncarew @eseidelGoogle @Hixie