Add support for raw key events on Fuchsia #6754
Conversation
| /// If there is no unicode code point, this value is zero. | ||
| final int codePoint; | ||
| } | ||
|
|
||
| /// Base class for raw key events. | ||
| /// | ||
| /// Raw key events pass through as much information as possible from the |
There was a problem hiding this comment.
"makes they" on line 89 is grammatically dubious, while you're here...
| @@ -110,6 +134,12 @@ RawKeyEvent _toRawKeyEvent(dynamic message) { | |||
| metaState: message['metaState'] ?? 0, | |||
There was a problem hiding this comment.
before the switch, maybe in the argument type, assert that message is a Map
There was a problem hiding this comment.
...and that it contains a key 'keymap'
There was a problem hiding this comment.
If there's no keymap, it will hit the default case and throw an exception
| hidUsage: message['hidUsage'] ?? 0, | ||
| codePoint: message['codePoint'] ?? 0, | ||
| ); | ||
| break; | ||
| default: | ||
| throw new FlutterError('Unknown keymap for key events: $keymap'); |
There was a problem hiding this comment.
how does this avoid crashing on iOS?
There was a problem hiding this comment.
We don't generate these messages on iOS.
There was a problem hiding this comment.
Maybe add a comment explaining this.
| hidUsage: message['hidUsage'] ?? 0, | ||
| codePoint: message['codePoint'] ?? 0, | ||
| ); | ||
| break; | ||
| default: | ||
| throw new FlutterError('Unknown keymap for key events: $keymap'); | ||
| } |
There was a problem hiding this comment.
just below here, assert that message has a 'type' key
There was a problem hiding this comment.
I've made this switch follow the pattern from the other switch, so you'll hit the default case and trigger an exception.
|
|
|
no tests? |
abarth
force-pushed
the
raw_keys_fuchsia
branch
from
c2df287
to
386154e
Compare
abarth
force-pushed
the
raw_keys_fuchsia
branch
from
386154e
to
fbe3fb2
Compare
See #6631