[shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
requested review from
cbracken,
cyanglaz,
reidbaker and
ditman
as code owners
stuartmorgan
requested changes
Jun 27, 2023
...ages/shared_preferences/shared_preferences_foundation/lib/shared_preferences_foundation.dart
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_android/lib/shared_preferences_android.dart
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_android/lib/shared_preferences_android.dart
Show resolved
Hide resolved
...ages/shared_preferences/shared_preferences_foundation/lib/shared_preferences_foundation.dart
Show resolved
Hide resolved
...hared_preferences/shared_preferences_foundation/test/shared_preferences_foundation_test.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_linux/lib/shared_preferences_linux.dart
Show resolved
Hide resolved
I reverted those changes, I also caught a mistake in one of the ios implementations returning void instead of bool. Sorry about the git reset, nothing else has changed besides that. |
stuartmorgan
approved these changes
Jun 28, 2023
packages/shared_preferences/shared_preferences_foundation/pigeons/messages.dart
Outdated
Show resolved
Hide resolved
...ages/shared_preferences/shared_preferences_windows/test/shared_preferences_windows_test.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_android/pigeons/messages.dart
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2023
…ithParameters methods to all platforms. (flutter/packages#4262)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 30, 2023
flutter/packages@d4752c4...53ed5a0 2023-06-30 [email protected] [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452) 2023-06-29 [email protected] [various] Remove unused flutter_driver dependencies (flutter/packages#4347) 2023-06-29 [email protected] [ci] Add LUCI version of dart unit tests (flutter/packages#4265) 2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189) 2023-06-29 [email protected] [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
clearWithParametersandgetAllWithParametersmethods.part of flutter/flutter#128948
precursor to #3794
awaiting #4261
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.