[camera_android] Support concurrently image capture and image streaming #4332
Conversation
camsim99
changed the title
| if (image == null) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Unrelated fix: acquireNextImage may return null, so added null check.
| @@ -659,7 +669,6 @@ public void onCaptureCompleted( | |||
| }; | |||
|
|
|||
| try { | |||
| captureSession.stopRepeating(); | |||
There was a problem hiding this comment.
Unrelated fix: This call should not be necessary for still capture to proceed.
camsim99
requested review from
johnmccutchan,
reidbaker,
bparrishMines and
gmackall
There was a problem hiding this comment.
LGTM
I believe we were originally concerned with attempting preview, image streaming, and still image capture simultaneously due to hardware limitations on some devices. But it looks like all hardware supports all three simultaneously: https://developer.android.com/reference/android/hardware/camera2/CameraDevice#regular-capture.
However they can be limited by resolutions.
Oh, I did not realize this, but that context makes sense. Definitely good to be aware of, though, if we start seeing related bugs. Thanks! |
camsim99
added
the
autosubmit
flutter/packages@53ed5a0...cdae854 2023-07-01 [email protected] Roll Flutter from ff838bc to aa5f4a2 (29 revisions) (flutter/packages#4363) 2023-07-01 [email protected] [tool] Add a flag to skip cleanup (flutter/packages#4357) 2023-07-01 [email protected] [file_selector] Endorse Android (flutter/packages#4329) 2023-07-01 [email protected] [google_sign_in] Convert Android to Pigeon (flutter/packages#4344) 2023-06-30 [email protected] [Pigeon] readme updates (flutter/packages#3705) 2023-06-30 [email protected] [camera_android] Support concurrently image capture and image streaming (flutter/packages#4332) 2023-06-30 [email protected] Prepare for utf8.encode() to return more precise Uint8List type (flutter/packages#4342) 2023-06-30 [email protected] [shared_preferences] Adds allowList to setPrefix method. (flutter/packages#3794) 2023-06-30 [email protected] Roll Flutter from 51bef1b to ff838bc (12 revisions) (flutter/packages#4346) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Properly configures surface needed for image capture when image streaming/recording is started to support concurrently still capture and image streaming.
Fixes flutter/flutter#125314.
Apologies for the many commits :(
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).