[camera] Camera with MediaSettings: platform implementations (federated) #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaSettings.low changed to const MediaSettings(resolutionPreset: ResolutionPreset.low).
Co-authored-by: Camille Simon <[email protected]>
Co-authored-by: Maurice Parrish <[email protected]>
mossmana
changed the title
jmagman
approved these changes
Mar 13, 2024
|
@stuartmorgan this is blocked on your review |
stuartmorgan
requested changes
Mar 14, 2024
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.h
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettingsAVWrapper.h
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettingsAVWrapper.h
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraSettingsTests.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m
Outdated
Show resolved
Hide resolved
|
@stuartmorgan Thank, you for review. Your suggestions are applied. |
|
@stuartmorgan Can you take a look when you have time? |
stuartmorgan
requested changes
Apr 4, 2024
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.h
Outdated
Show resolved
Hide resolved
packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m
Outdated
Show resolved
Hide resolved
|
@stuartmorgan suggestions applied |
stuartmorgan
approved these changes
Apr 5, 2024
suggestions applied AssertPositiveNumberOrNil: macro to inline formatted .class to +class Update packages/camera/camera_avfoundation/ios/Classes/FLTCamMediaSettings.m Co-authored-by: Jenn Magder <[email protected]> applied suggestions. 02/25/2024. dependency injection (DI) variant for unit test ObjC suggestions applied suggestion applied updated camera_platform_interface versions reverted changes to camera merged 01/07/2024 refactored and co0mmented warning suppressions. renamed MediaRecorderBuilder.RecordingParameters merged 12/07/2023
PROGrand
force-pushed
the
camera-with-settings-platform-implementations
branch
from
faa7b8f
to
adf6929
Compare
stuartmorgan
requested changes
Apr 5, 2024
There was a problem hiding this comment.
A bunch of files showed as changed since review, and because of the squash I can't tell if that's a GitHub artifact of the squash, or actual changes, so I re-reviewed those files. That turned up a few more minor comments which may be things I just didn't previously review, but I've flagged them regardless. Sorry that means one more quick pass.
packages/camera/camera_avfoundation/example/lib/camera_controller.dart
Outdated
Show resolved
Hide resolved
two lines
|
@stuartmorgan resolved |
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 8, 2024
flutter/packages@764d997...6b4d8b6 2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480) 2024-04-07 [email protected] Add limit to image_picker_platform_interface (flutter/packages#6434) 2024-04-07 [email protected] Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478) 2024-04-05 [email protected] Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470) 2024-04-05 [email protected] [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
flutter/packages@764d997...6b4d8b6 2024-04-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/packages#6480) 2024-04-07 [email protected] Add limit to image_picker_platform_interface (flutter/packages#6434) 2024-04-07 [email protected] Roll Flutter from 477ebd8 to 98d23f7 (16 revisions) (flutter/packages#6478) 2024-04-05 [email protected] Roll Flutter from ac2ca93 to 477ebd8 (32 revisions) (flutter/packages#6470) 2024-04-05 [email protected] [camera] Camera with MediaSettings: platform implementations (federated) (flutter/packages#5223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
…ed) (flutter#5223) This is the `platform implementations` part of `camera` PR flutter#3586. `camera_platform_interface: 2.6.0` merged and published in PR flutter#3615. Now repeating steps 3,4 (see [Changing federated plugins](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins)), because `camera/camera` depends on implementations `camera/camera_android`, `camera/camera_web` etc.
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…ed) (flutter#5223) ## Platform implementations of federated plugin This is the `platform implementations` part of `camera` PR flutter#3586. `camera_platform_interface: 2.6.0` merged and published in PR flutter#3615. Now repeating steps 3,4 (see [Changing federated plugins](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins)), because `camera/camera` depends on implementations `camera/camera_android`, `camera/camera_web` etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform implementations of federated plugin
This is the
platform implementationspart ofcameraPR #3586.camera_platform_interface: 2.6.0merged and published in PR #3615.Now repeating steps 3,4 (see Changing federated plugins), because
camera/cameradepends on implementationscamera/camera_android,camera/camera_webetc.