Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 #5520

Merged
merged 13 commits into from
Nov 30, 2023
Merged

[cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 #5520

merged 13 commits into from
Nov 30, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Nov 29, 2023 •
edited by ditman
Loading

  • Migrates the web implementation of cross_file from dart:html to package:web, so it can be compiled with dart2wasm.
  • Bumps minimum sdk version.

Part of flutter/flutter#117022

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@kevmoo kevmoo requested a review from ditman as a code owner November 29, 2023 22:32
@kevmoo
Copy link
Contributor Author

kevmoo commented Nov 30, 2023

CC @srujzs

@kevmoo kevmoo changed the title [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.1 [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 Nov 30, 2023
srujzs
srujzs approved these changes Nov 30, 2023
View reviewed changes
packages/cross_file/lib/src/types/html.dart Outdated Show resolved Hide resolved
packages/cross_file/test/x_file_html_test.dart Outdated Show resolved Hide resolved
packages/cross_file/test/x_file_html_test.dart Outdated Show resolved Hide resolved
packages/cross_file/test/x_file_html_test.dart Show resolved Hide resolved
packages/cross_file/test/x_file_html_test.dart Outdated Show resolved Hide resolved
ditman
ditman approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for migrating the tests as well!

@ditman
Copy link
Member

ditman commented Nov 30, 2023

Please, @kevmoo remember to follow this next time: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 30, 2023
@auto-submit auto-submit bot merged commit 7a11e2d into main Nov 30, 2023
80 checks passed
@auto-submit auto-submit bot deleted the cross_file_web branch November 30, 2023 23:23
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2023
@engine-flutter-autoroll
7a11e2d [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (fl…
bd76709 
…utter/packages#5520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 1, 2023
@engine-flutter-autoroll
7a11e2d [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (fl…
7b4fde2 
…utter/packages#5520)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 4, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 4, 2023
@engine-flutter-autoroll
7a11e2d [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (fl…
9746339 
…utter/packages#5520)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 4, 2023
@engine-flutter-autoroll
Roll Packages from bc72d15 to 5d9874f (9 revisions) (#139480)
df88e3a 
flutter/packages@bc72d15...5d9874f

2023-12-02 [email protected] Roll Flutter from 918e336 to d861ce4 (29 revisions) (flutter/packages#5542)
2023-12-02 [email protected] [gsi_web] Do not initialize CodeClient if scopes are empty. (flutter/packages#5537)
2023-12-01 [email protected] Reenable macOS 13 tests (flutter/packages#5494)
2023-12-01 [email protected] [flutter_image] Adopt code excerpts in README (flutter/packages#5498)
2023-11-30 [email protected] [cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (flutter/packages#5520)
2023-11-30 [email protected] [google_maps_flutter] Add support for version 8 of the iOS SDK (flutter/packages#5528)
2023-11-30 [email protected] [pointer_interceptor] Re-land: Add platform interface (flutter/packages#5525)
2023-11-30 [email protected] [google_sign_in] Add server auth code retrieval to gis_client (flutter/packages#5358)
2023-11-30 [email protected] Roll Flutter from 5e5b529 to 918e336 (14 revisions) (flutter/packages#5526)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@kevmoo @HugoOlthof
[cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (flutter#5520)
fcce9b0 
* Migrates the web implementation of `cross_file` from `dart:html` to `package:web`, so it can be compiled with `dart2wasm`.
* Bumps minimum sdk version.

Part of flutter/flutter#117022
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbaker reidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbaker reidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@kevmoo @arc-yong
[cross_file] Migrate to pkg:web, bump min SDK to Dart 3.2 (flutter#5520)
964cf46 
* Migrates the web implementation of `cross_file` from `dart:html` to `package:web`, so it can be compiled with `dart2wasm`.
* Bumps minimum sdk version.

Part of flutter/flutter#117022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: cross_file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevmoo @ditman @srujzs