-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pigeon] fix named parameters in flutter api #5663
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@@ -277,7 +277,7 @@ class Parameter extends NamedType { | |||
bool? isPositional, | |||
bool? isRequired, | |||
super.documentationComments, | |||
}) : isNamed = isNamed ?? true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes existing tests that don't specify this but still assume it's false.
Since this wasn't used anywhere besides toString, I don't consider this a breaking change.
Can you add an integration test for this as well? If you need guidance on this, let me know. This will also need versioning (changelog, pubspec, and generator_tools.dart) |
@tarrinneal Thanks for reviewing so far. I updated the versioning stuff and started with the integration tests, but I need your help on this: I added some appropriate methods here: packages/pigeon/pigeons/core_tests.dart |
There's actually another bug that's surfaced from this (I actually intended for this feature to only be on hostApi's). I'm going to patch into this pr, unless you prefer I don't. |
fixes flutter/flutter#140045 replaces #5663 as no longer needed.
fixes flutter/flutter#140045 replaces flutter#5663 as no longer needed.
Fixes flutter/flutter#140045
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.