Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rfw] Add support for widget builders #5907

Merged
merged 22 commits into from
Mar 6, 2024
Merged

Conversation

tugorez
Copy link
Contributor

@tugorez tugorez commented Jan 17, 2024

This PR adds support for widget builders.

flutter/flutter#141658

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Jan 17, 2024
@tugorez tugorez changed the title Add the tokenizer changes Intr Jan 18, 2024
@tugorez tugorez changed the title Intr [RFW] Add parser support for functions. Jan 18, 2024
@tugorez tugorez changed the title [RFW] Add parser support for functions. [rfw] Add parser support for functions. Jan 18, 2024
@tugorez tugorez changed the title [rfw] Add parser support for functions. [rfw] Add support for widget builders Jan 25, 2024
@tugorez tugorez changed the title [rfw] Add support for widget builders [rfw] Add support for functions Jan 25, 2024
@tugorez tugorez changed the title [rfw] Add support for functions [rfw] Add support for widget builders Jan 25, 2024
@tugorez tugorez requested a review from Hixie March 6, 2024 17:40
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tugorez tugorez added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2024
@auto-submit auto-submit bot merged commit 6701c9e into flutter:main Mar 6, 2024
78 checks passed
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
@tugorez tugorez deleted the rfw-builder branch March 7, 2024 14:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 7, 2024
flutter/packages@9b88dbc...6701c9e

2024-03-06 [email protected] [rfw] Add support for widget builders (flutter/packages#5907)
2024-03-06 [email protected] [in_app_purchase_storekit] Handle translation of errors nested in dictionaries (flutter/packages#6277)
2024-03-06 [email protected] Roll Flutter from 3b5a2ec to 8f84f3f (18 revisions) (flutter/packages#6276)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: rfw Remote Flutter Widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants