[url_launcher] Add support for setting show title on Chrome Custom Tabs #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Alex-Usmanov Is this ready for re-review? The blocking PR has landed. |
|
Yes, sir. It is ready for re-review |
stuartmorgan
approved these changes
May 31, 2024
There was a problem hiding this comment.
Sorry for the delay; LGTM with one comment nit.
@gmackall Could you do the secondary review here?
| return InAppWebViewConfiguration( | ||
| enableJavaScript: config.enableJavaScript, | ||
| enableDomStorage: config.enableDomStorage, | ||
| headers: config.headers, | ||
| ); | ||
| } | ||
|
|
||
| /// Converts an (app-facing) [BrowserConfiguration] to a (platform interface) | ||
| /// [InApp]. |
There was a problem hiding this comment.
[InAppBrowserConfiguration]
gmackall
approved these changes
May 31, 2024
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2024
flutter/packages@11e192a...586faa6 2024-06-05 [email protected] [google_sign_in_web] Update button_tester to use web_only library. (flutter/packages#6868) 2024-06-05 [email protected] Roll Flutter from c246ecd to 27e0656 (17 revisions) (flutter/packages#6875) 2024-06-05 [email protected] [path_provider] Skip verifying sample file on macOS (flutter/packages#6874) 2024-06-05 [email protected] [google_maps_flutter] Custom marker size improvements (flutter/packages#4055) 2024-06-05 [email protected] [rfw] Material slider widget (flutter/packages#6610) 2024-06-04 [email protected] [ci] Manual roll Flutter to c246ecd (84 revisions) + fixes (flutter/packages#6863) 2024-06-04 [email protected] Correcting the typo of Flutter in projects (flutter/packages#6850) 2024-06-04 [email protected] [google_maps_flutter] Custom marker size improvements - platform impls (flutter/packages#6826) 2024-06-04 [email protected] Avoid cumbersome formatter workaround (flutter/packages#6573) 2024-06-04 [email protected] Clean Xcode project before analyzing and testing (flutter/packages#6842) 2024-06-03 [email protected] [pigeon] Kotlin/Java method overloading for the `setUp` method (flutter/packages#6843) 2024-06-03 [email protected] [url_launcher] Add support for setting show title on Chrome Custom Tabs (flutter/packages#6097) 2024-06-03 [email protected] Revert "Roll Flutter from c85fa6a to 7eebe29 (#6836)" (flutter/packages#6860) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
…bs (flutter#6097) - Adds showTitle option to platform interface & app-facing api - Makes use of that parameter on android platform in order to set show title on Chrome Custom Tabs, when it is being used - Makes android implementation use both legacy & new api (instead of passthrough from new to legacy), in order to allow use of the aforementioned parameter - Adds a button to the example to test this parameter - Adds tests  (Notice title at the top of the page "CyLog Software - HTTP ...") flutter/flutter#136784
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Notice title at the top of the page "CyLog Software - HTTP ...")
flutter/flutter#136784
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.