Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router]: fix leaking GoRouter.replace and GoRouter.pushReplacement completer, preserve it #6451

Closed
wants to merge 3 commits into from
Closed

[go_router]: fix leaking GoRouter.replace and GoRouter.pushReplacement completer, preserve it #6451

wants to merge 3 commits into from

Commits on Apr 3, 2024

  1. [go_router]: fix leaking GoRouter.replace and GoRouter.pushReplacemen… 

    …t completer, preserve it (#141251)

When route from the stack is replaced, its completer is lost,
and causes futures in routes chain to never finish.
    @pawlowskim
    pawlowskim committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    7a36b7d View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md and pubspec.yaml

    @pawlowskim
    pawlowskim committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    7a01c23 View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @pawlowskim
    pawlowskim committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    cca5798 View commit details
    Browse the repository at this point in the history