Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redistribute CODEOWNERS #6457

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 3, 2024

No description provided.

@jmagman jmagman self-assigned this Apr 3, 2024
@jmagman jmagman marked this pull request as ready for review April 4, 2024 17:32
packages/in_app_purchase/in_app_purchase_storekit/** @louisehsu
packages/ios_platform_images/** @jmagman
packages/local_auth/local_auth_darwin/** @louisehsu
packages/path_provider/path_provider_foundation/** @jmagman
packages/pigeon/**/ios/**/* @hellohuanlin
packages/pointer_interceptor/pointer_interceptor_ios/** @ditman
Copy link
Member Author

@jmagman jmagman Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouiseHsu suggested she take pointer_interceptor_ios, are you cool with that @ditman?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200% cool with it, thanks @LouiseHsu :)

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cbracken changes lgtm.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@LouiseHsu LouiseHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

joining the lgtm train :)

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2024
@auto-submit auto-submit bot merged commit 8d01c5c into flutter:main Apr 4, 2024
78 checks passed
@jmagman jmagman deleted the CODEOWNERS-darwin branch April 4, 2024 23:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 5, 2024
flutter/packages@dce6f0c...764d997

2024-04-05 [email protected] [video_player] Call `super.dispose` last in README example (flutter/packages#6051)
2024-04-04 [email protected] Fix macos_platform_tests package build times out when built for all packages (flutter/packages#6463)
2024-04-04 [email protected] Redistribute CODEOWNERS (flutter/packages#6457)
2024-04-04 [email protected] Roll Flutter from e868e2b to ac2ca93 (25 revisions) (flutter/packages#6460)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
flutter/packages@dce6f0c...764d997

2024-04-05 [email protected] [video_player] Call `super.dispose` last in README example (flutter/packages#6051)
2024-04-04 [email protected] Fix macos_platform_tests package build times out when built for all packages (flutter/packages#6463)
2024-04-04 [email protected] Redistribute CODEOWNERS (flutter/packages#6457)
2024-04-04 [email protected] Roll Flutter from e868e2b to ac2ca93 (25 revisions) (flutter/packages#6460)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants