Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dynamic_layouts] Remove the dynamic_layouts package #6830

Merged
merged 1 commit into from
May 29, 2024

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented May 29, 2024

Fixes flutter/flutter#148979

Also related: flutter/flutter#149252

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2024
@auto-submit auto-submit bot merged commit e35f291 into flutter:main May 29, 2024
74 checks passed
@stuartmorgan
Copy link
Contributor

Thanks for this cleanup! It's one of the packages that's been on my list to audit.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 30, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 30, 2024
flutter/packages@31d3329...910fabb

2024-05-29 [email protected] Amend package:web tweaks to allow package:web roll (flutter/packages#6793)
2024-05-29 [email protected] Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6456)
2024-05-29 [email protected] [google_maps_flutter] Undeprecate BitmapDescriptor methods (flutter/packages#6832)
2024-05-29 [email protected] Migrate CameraX from SurfaceTexture to SurfaceProducer. (flutter/packages#6462)
2024-05-29 [email protected] Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6461)
2024-05-29 [email protected] [dynamic_layouts] Remove the dynamic_layouts package (flutter/packages#6830)
2024-05-29 [email protected] [camerax] Add notes about Android permissions (flutter/packages#6741)
2024-05-29 [email protected] [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6742)
2024-05-29 [email protected] Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (flutter/packages#6829)
2024-05-29 [email protected] [rfw] Migrate deprecated doc references (flutter/packages#6744)
2024-05-29 [email protected] [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetStateProperty (flutter/packages#6743)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
flutter/packages@31d3329...910fabb

2024-05-29 [email protected] Amend package:web tweaks to allow package:web roll (flutter/packages#6793)
2024-05-29 [email protected] Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6456)
2024-05-29 [email protected] [google_maps_flutter] Undeprecate BitmapDescriptor methods (flutter/packages#6832)
2024-05-29 [email protected] Migrate CameraX from SurfaceTexture to SurfaceProducer. (flutter/packages#6462)
2024-05-29 [email protected] Migrate `camera/android` from `SurfaceTexture`->`SurfaceProducer`. (flutter/packages#6461)
2024-05-29 [email protected] [dynamic_layouts] Remove the dynamic_layouts package (flutter/packages#6830)
2024-05-29 [email protected] [camerax] Add notes about Android permissions (flutter/packages#6741)
2024-05-29 [email protected] [Re-land] Bump legacy all_packages project AGP version to 7.0.0, Gradle version to 7.0.2 (flutter/packages#6742)
2024-05-29 [email protected] Roll Flutter from a1a33e6 to c85fa6a (20 revisions) (flutter/packages#6829)
2024-05-29 [email protected] [rfw] Migrate deprecated doc references (flutter/packages#6744)
2024-05-29 [email protected] [flutter_adaptive_scaffold] Migrate MaterialStateProperty to WidgetStateProperty (flutter/packages#6743)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@binSaed
Copy link

binSaed commented Jun 3, 2024

we are using dynamic_layouts in our app
Could you tell me where I can find this package after it is deleted?

@Piinks @stuartmorgan @jmagman

Screenshot 2024-06-03 at 11 52 53 AM

@binSaed
Copy link

binSaed commented Jun 3, 2024

If anyone faces the same issue

dynamic_layouts:
    git:
      url: https://github.com/binSaed/dynamic_layouts.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete dynamic_layouts from the packages repo
4 participants