[two_dimensional_scrollables] Adds generics to the callbacks and builders of TreeView #6864
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Hey @baumths thanks for sending a PR! You beat me to it! :)
Can you add a test that prevents us from regressing this in the future? Just creating an instance of those callbacks and builders that does not have the type casts should cover it, like in the comment you left on the TreeSliver PR.
|
Added a test but I'm not sure if I did it the right way, never written such a test. Should I expect something else? I've also updated the tree view tests to use the correct type in the callbacks, hope that's ok. |
baumths
force-pushed
the
tree-view-generics
branch
from
deba315
to
bfa758c
Compare
Co-authored-by: Kate Lovett <[email protected]>
baumths
force-pushed
the
tree-view-generics
branch
from
27c733b
to
d5d0a4d
Compare
|
I need to get a second stamp for this, will find another reviewer |
matanlurey
added
the
autosubmit
…and builders of TreeView (flutter/packages#6864)
flutter/packages@586faa6...8a2c4e4 2024-06-06 [email protected] Revert "Migrate `video_player/android` from `SurfaceTexture`->`SurfaceProducer`." (flutter/packages#6882) 2024-06-06 [email protected] [two_dimensional_scrollables] Adds generics to the callbacks and builders of TreeView (flutter/packages#6864) 2024-06-06 [email protected] Run tests on macOS 13 or 14 (flutter/packages#6877) 2024-06-06 [email protected] Disable sandboxing directly for macOS tests (flutter/packages#6880) 2024-06-06 [email protected] [pigeon] Moves all codec logic to singular custom codec (flutter/packages#6600) 2024-06-06 [email protected] Roll Flutter (stable) from a14f74f to 761747b (6 revisions) (flutter/packages#6878) 2024-06-06 [email protected] Roll Flutter from 27e0656 to 4608a89 (17 revisions) (flutter/packages#6876) 2024-06-06 [email protected] Disable sandboxing for macOS tests in CI (flutter/packages#6866) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…ders of TreeView (flutter#6864) This PR adds generics to the callbacks and builders of the TreeView widget. This removes the need to type cast the content of a TreeViewNode. Fixes flutter/flutter#149656
This PR adds generics to the callbacks and builders of the TreeView widget. This removes the need to type cast the content of a TreeViewNode.
Fixes flutter/flutter#149656
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.