Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[interactive_media_ads] Adds internal wrapper for iOS native IMACompanionAdSlot and IMACompanionDelegate #7889

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Oct 17, 2024

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title impl [interactive_media_ads] Adds internal wrapper for iOS native IMACompanionAdSlot and IMACompanionDelegate Oct 18, 2024
@bparrishMines bparrishMines marked this pull request as ready for review October 28, 2024 15:23
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2024
@auto-submit auto-submit bot merged commit c658ca2 into flutter:main Oct 28, 2024
76 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 28, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 29, 2024
flutter/packages@e0c4f55...028027e

2024-10-29 [email protected] [various] Remove multiDexEnabled (flutter/packages#7956)
2024-10-28 [email protected] Roll Flutter from 5a11904 to 3fb95c7 (16 revisions) (flutter/packages#7948)
2024-10-28 [email protected] [interactive_media_ads] Adds internal wrapper for iOS native `IMACompanionAdSlot` and `IMACompanionDelegate` (flutter/packages#7889)
2024-10-27 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.2.1 to 4.2.2 (flutter/packages#7919)
2024-10-26 [email protected] Roll Flutter from 4faa4a4 to 5a11904 (67 revisions) (flutter/packages#7937)
2024-10-25 [email protected] Drop deprecated web library (flutter/packages#7926)
2024-10-25 [email protected] [video_player_web] Don't modify volume when muting video (flutter/packages#7845)
2024-10-25 [email protected] Roll Flutter (stable) from 2663184 to 6031040 (3 revisions) (flutter/packages#7930)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: interactive_media_ads Plugin for IMA SDK platform-android platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants