Applied Gradle Plugins Declaratively for Most Remaining Plugin Example Apps (Part 3) #8037
Conversation
jesswrd
changed the title
jesswrd
added
override: no versioning needed
jesswrd
force-pushed
the
i1152656-migrate-remaining-ex-plugins
branch
2 times, most recently
from
8dcb7ae
to
4bcfa6f
Compare
| android { | ||
| namespace 'io.flutter.plugins.cameraexample' | ||
| compileSdk flutter.compileSdkVersion | ||
|
|
||
|
|
||
| defaultConfig { | ||
| applicationId "io.flutter.plugins.cameraexample" | ||
| minSdkVersion flutter.minSdkVersion | ||
| targetSdkVersion 28 | ||
| minSdkVersion 21 |
There was a problem hiding this comment.
Isn't this undoing what @stuartmorgan just did in #8035?
There was a problem hiding this comment.
yup nice catch. added back.
jesswrd
changed the title
jesswrd
requested review from
camsim99,
matanlurey,
gmackall,
reidbaker,
tarrinneal,
stuartmorgan and
bparrishMines
as code owners
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: code refactor with no semantic change |
|
@camsim99 CI failure is unrelated to current PR. @stuartmorgan Can I land on red? Here are potentially related issues: |
jesswrd
changed the title
Drive-by answer: In general I would not ignore CI failures and land on red. In this particular case their might not be any consequences, but it's easy to accidentally make a bad situation worse, often in hidden or complex ways. If there is a test that is not stable enough (i.e. a re-run doesn't turn it green), as potentially mentioned in the above issues, I'd disable the test for now, and merge this PR with a truly green CI status. (There are exceptional cases where this guidance might not hold - like a security vulnerability or severe regression where the cost of potentially breaking a test is lower than not landing code, but I wouldn't find updating example apps to be one). I am also happy to review a PR temporarily disabling a flaky test. |
|
@matanlurey Gotcha, I'll send that PR temporarily disabling the flaky tests. Thanks! |
Is it?
This PR changes the target SDK to a value >=31, and you are referencing an issue saying the tests break if the target SDK is >=31. So isn't this PR breaking the integration tests?
No, we don't land on red unless it's to fix the tree. |
I have to bump the target sdk version to at least 33 to avoid an error. Will skip related working tests in this PR and add a note in the PR description. |
# Conflicts: # packages/camera/camera/example/android/app/build.gradle # packages/camera/camera_android/example/android/app/build.gradle # packages/camera/camera_android_camerax/example/android/app/build.gradle
jesswrd
force-pushed
the
i1152656-migrate-remaining-ex-plugins
branch
from
29039ca
to
d11f470
Compare
* main: [ci] Take screenshot when native drive test is taking longer than 10 minutes (flutter#8050) Applied Gradle Plugins Declaratively for Most Remaining Plugin Example Apps (Part 3) (flutter#8037) [pigeon]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 2.0.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7867) [gradle]: Bump androidx.test.ext:junit-ktx from 1.1.5 to 1.2.1 in /packages/shared_preferences/shared_preferences_android/android (flutter#8097) [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 2.0.20 to 2.0.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7869) [gradle]: Bump org.hamcrest:hamcrest from 2.2 to 3.0 in /packages/espresso/android (flutter#8092) [pigeon]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in /packages/pigeon/platform_tests/test_plugin/android (flutter#7868) [shared_pref]: Bump io.mockk:mockk from 1.13.12 to 1.13.13 in /packages/shared_preferences/shared_preferences_android/android (flutter#7866) Add autosubmit label to dependabot PRs (flutter#8101) Roll Flutter from 0e2d55e0e7b2 to b3818f6b5979 (23 revisions) (flutter#8118) [gradle]: Bump org.mockito.kotlin:mockito-kotlin from 4.1.0 to 5.4.0 in /packages/interactive_media_ads/android (flutter#8095)
Updated applying gradle plugins from usage of imperative apply to usage of declarative blocks {} apply for 25 remaining plugin example apps. Intending on updating all android example apps under packages.
Here are previous bulk migrations from imperative apply to declarative apply:
#7968
#8019
Previously migrated applying path_provider plugin example app from imperatively to declaratively in this PR here. Tests for changes in the linked PR above.
More information on Flutter Gradle Pluggin Apply here
All instances of
minSdkVersionfor example plugin apps useflutter.minSdkVersioninstead of the hard-coded version #8035.Note: Not migrating
camera,camera_android,camera_android_cameraxuntil integration tests are updated.Partially addresses #152656
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.