[google_maps_flutter] Fix detection of WebAssembly compatibility #8102
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
packages/google_maps_flutter/google_maps_flutter/lib/src/platform.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart
Outdated
Show resolved
Hide resolved
|
PTAL – also ponder test exemption |
|
test-exempt: removing code |
auto-submit
bot
removed
the
autosubmit
flutter/packages@b164be3...c1eabf5 2024-11-16 49699333+dependabot[bot]@users.noreply.github.com [gradle]: Bump org.mockito.kotlin:mockito-kotlin from 4.1.0 to 5.4.0 in /packages/interactive_media_ads/android (flutter/packages#8095) 2024-11-16 [email protected] [google_identity_services_web] Migrate all types to JSObject (flutter/packages#8053) 2024-11-15 49699333+dependabot[bot]@users.noreply.github.com [file_selector]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/file_selector/file_selector_android/android (flutter/packages#7982) 2024-11-15 [email protected] [web_benchmarks] Remove `WebRenderer` enum. (flutter/packages#8103) 2024-11-15 [email protected] [google_maps_flutter] Fix detection of WebAssembly compatibility (flutter/packages#8102) 2024-11-15 [email protected] Roll Flutter from ed553d1 to 0e2d55e (40 revisions) (flutter/packages#8106) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
No description provided.