Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_messaging]Added modern iOS notification types #1009

Closed

Conversation

kflip
Copy link

@kflip kflip commented Dec 28, 2018

New authorization options (formerly known as UIUserNotificationType) have been provided by apple with iOS10 and iOS12:
provisional (aka: silent notification), criticalAlert, notificationSetting and carPlay

This pull request intends to be backwards compatible until iOS8. Registering of any UIUserNotificationType or UNAuthorizationOptions is possible, if the operating system supports it.

A basic implementation of UNUserNotificationCenter for iOS10+ was necessary to request permission for these new types.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@kflip
Copy link
Author

kflip commented Dec 28, 2018

The tests fail since they are done with Xcode9 and iOS11. Is there a chance to update the test hosts?

@cyanglaz cyanglaz changed the title Added modern iOS notification types [firebase_messaging]Added modern iOS notification types Feb 22, 2019
@yevyevyev
Copy link

It's almost a year, the methods are deprecated, messaging needs this feature

@cyanglaz
Copy link
Contributor

flutterfire has been re-homed to https://github.com/FirebaseExtended/FlutterFire
Please feel free to open a PR there, thanks.
I'm closing this PR here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants