[google_sign_in] Fix serverAuthCode getToken on iOS #2788

yamarkz · 2020-05-21T15:13:13Z

Description

The method of getting serverAuthCode was not correct.
I fixed it and confirmed that my local was able to get it.

here are

try {
  final _googleSignIn = GoogleSignIn(
    scopes: [
      'email',
      'https://www.googleapis.com/auth/contacts.readonly',
    ],
  );
  final googleSignInAccount = await _googleSignIn.signIn();
  final googleSignInAuthentication = await googleSignInAccount.authentication;
  final code = googleSignInAuthentication.serverAuthCode;
  print(code);
} catch (error) {
  print(error);
}

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

scaraux · 2020-05-29T18:28:28Z

@yamarkz Hey I am pulling from your branch but the app crashes immediatly when google sign in resolves, any idea?

0 CoreFoundation 0x00007fff23e3cf0e __exceptionPreprocess + 350 1 libobjc.A.dylib 0x00007fff50ba89b2 objc_exception_throw + 48 2 CoreFoundation 0x00007fff23ecfa51 _CFThrowFormattedException + 194 3 CoreFoundation 0x00007fff23eda4a6 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:].cold.4 + 38 4 CoreFoundation 0x00007fff23e9b787 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 247 5 CoreFoundation 0x00007fff23e38e11 +[NSDictionary dictionaryWithObjects:forKeys:count:] + 49 6 Runner 0x00000001099fe6e4 __49-[FLTGoogleSignInPlugin handleMethodCall:result:]_block_invoke + 452

yamarkz · 2020-05-30T01:00:05Z

@scaraux
Thank you for comment.
Do you have the SERVER_CLIENT_ID set to GoogleService-Info.plist ?
I'm able to get serverAuthCode in my environment.

scaraux · 2020-05-30T21:33:37Z

@scaraux
Thank you for comment.
Do you have the SERVER_CLIENT_ID set to GoogleService-Info.plist ?
I'm able to get serverAuthCode in my environment.

If you are talking about passing clientId in the constructor, yes I did.

EDIT: I didn't know about this. I added it to the .plist file. Thank you.
Looking forward for your pull request to be merged.

abhishek199-dhn · 2020-06-03T08:30:24Z

I need this fix to get the serverAuthCode such that I can get a refresh token at the backend side to use google API.
By when we can expect this to be merged?

scaraux · 2020-06-05T21:06:04Z

I need this fix to get the serverAuthCode such that I can get a refresh token at the backend side to use google API.
By when we can expect this to be merged?

In the meantime you can always do this:
pubspec.yaml

  google_sign_in:
    git:
      url: [email protected]:yamarkz/plugins.git
      path: packages/google_sign_in/google_sign_in
      ref: fix-server-auth-code-get-token

Don't forget to replace it when it's merged

JonasABR · 2020-06-19T14:31:48Z

@yamarkz & @scaraux I'm trying to reference your project to test it, cause I also need this token in my project, but everytime after login when i try to access anything from the GoogleSignInAccount returned object, I get a crash in my app.

*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff23e3cf0e __exceptionPreprocess + 350
	1   libobjc.A.dylib                     0x00007fff50ba89b2 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff23ecfa51 _CFThrowFormattedException + 194
	3   CoreFoundation                      0x00007fff23eda4a6 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:].cold.4 + 38
	4   CoreFoundation                      0x00007fff23e9b787 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 247
	5   CoreFoundation                      0x00007fff23e38e11 +[NSDictionary dictionaryWithObjects:forKeys:count:] + 49
	6   Runner                              0x0000000100e7df94 __49-[FLTGoogleSignInPlugin handleMethodCall:result:]_block_invoke + 452
	7   Runner  <…>
Lost connection to device.

chakrihacker · 2020-06-22T12:41:56Z

@JonasABR Add server_client_id to your plist or else it keeps crashing

Dahlgren · 2020-07-22T22:41:48Z

packages/google_sign_in/google_sign_in/ios/Classes/FLTGoogleSignInPlugin.m

@@ -112,6 +112,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
      result(error != nil ? getFlutterError(error) : @{
        @"idToken" : authentication.idToken,
        @"accessToken" : authentication.accessToken,
+        @"serverAuthCode" : currentUser.serverAuthCode,


When app is started with an older Google Sign In state the currentUser.serverAuthCode can be nil and this will cause a crash since nil can't be inserted into NSDictionary

That's right, I had this behaviour also.

Hey guys, can you please detail how to reproduce this issue? We've tried a few scenarios with this branch, but none caused a crash. @Dahlgren

It occurs when an existing session with Google Sign In is reused. The serverAuthCode only exists on initial login. If the existing session is flushed (logged out) and a new session is created the serverAuthCode will exist, if applicable.

assemmarwan · 2020-07-28T14:11:47Z

@scaraux
Thank you for comment.
Do you have the SERVER_CLIENT_ID set to GoogleService-Info.plist ?
I'm able to get serverAuthCode in my environment.

I don't have this key in the .plist downloaded from Firebase. There are three Client IDs:

CLIENT_ID
REVERSED_CLIENT_ID
ANDROID_CLIENT_ID

Below are all the keys in the .plist

Can you please guide me.

EDIT: Finally I found the solution. You'd need to manually add the key SERVER_CLIENT_ID which is the client id of the Web Application. The documentation need to be updated mentioning this.

JonasABR · 2020-09-07T15:58:34Z

This been open for a long time and still no conclusion? I particulary really need this feature working in iOS & Android. The android branch is also open for a long time. Wanted to avoid having it locally.

scaraux · 2020-09-10T22:45:19Z

This been open for a long time and still no conclusion? I particulary really need this feature working in iOS & Android. The android branch is also open for a long time. Wanted to avoid having it locally.

Same thing here. This is bad. Triage has not been updated in over a month
https://github.com/flutter/plugins/projects/3#card-43160874

I understand this is open source and people have other priorities, let us know if we can do anything.

scaraux · 2020-11-16T20:38:45Z

Guys, we really need this merged. Please...

scaraux · 2021-02-17T21:41:52Z

@stuartmorgan is there anything you can do to get this merged? Been open for NINE months now...

stuartmorgan · 2021-02-18T01:27:35Z

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review it. As explained in CONTRIBUTING.md, votes for the corresponding issue are the primary way we’re prioritizing non-trivial reviews, so we encourage anyone interested in this PR to vote for the corresponding issue.

Note that based on the discussion above it appears that this PR is not correct as-is (not correctly handling nil values in the ObjC code), and it's also missing tests, so wouldn't be mergeable as-is. Addressing the known issues and adding tests would be important steps toward making this reviewable and landable.

yamarkz · 2021-02-18T10:46:05Z

I'm sorry that this PR will not be merged.
I have no desire to merge and use this PR, so I will close it.
If you want to use it as a public package, please create a similar PR. Thanks.

@scaraux @stuartmorgan

Google_sign_in: Fix "serverAuthCode getToken" on iOS

41c512c

googlebot added the cla: yes label May 21, 2020

yamarkz added 2 commits May 22, 2020 00:29

Version bump

595835c

Update CHANGELOG.md

5e8466c

zeeshanhussain mentioned this pull request May 29, 2020

Google Sign In 4.5.1 - ServerAuthCode returns null value flutter/flutter#57712

Closed

Dahlgren reviewed Jul 22, 2020

View reviewed changes

Zaheer6110 mentioned this pull request Jul 29, 2020

Google Sign In 4.5.1 - ServerAuthCode returns null value for Web flutter/flutter#62474

Closed

assemmarwan approved these changes Nov 10, 2020

View reviewed changes

Fix conflict error

62c60f4

yamarkz requested review from cyanglaz and mehmetf as code owners November 11, 2020 23:13

stuartmorgan added the p: google_sign_in label Jan 29, 2021

stuartmorgan added backlog platform-ios labels Feb 18, 2021

yamarkz closed this Feb 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_sign_in] Fix serverAuthCode getToken on iOS #2788

[google_sign_in] Fix serverAuthCode getToken on iOS #2788

yamarkz commented May 21, 2020 •

edited

Loading

scaraux commented May 29, 2020

yamarkz commented May 30, 2020

scaraux commented May 30, 2020 •

edited

Loading

abhishek199-dhn commented Jun 3, 2020 •

edited

Loading

scaraux commented Jun 5, 2020

JonasABR commented Jun 19, 2020 •

edited

Loading

chakrihacker commented Jun 22, 2020

Dahlgren Jul 22, 2020

JonasABR Jul 23, 2020

douglasiacovelli Nov 9, 2020

Dahlgren Nov 9, 2020

assemmarwan commented Jul 28, 2020 •

edited

Loading

JonasABR commented Sep 7, 2020

scaraux commented Sep 10, 2020 •

edited

Loading

scaraux commented Nov 16, 2020

scaraux commented Feb 17, 2021

stuartmorgan commented Feb 18, 2021

yamarkz commented Feb 18, 2021

[google_sign_in] Fix serverAuthCode getToken on iOS #2788

[google_sign_in] Fix serverAuthCode getToken on iOS #2788

Conversation

yamarkz commented May 21, 2020 • edited Loading

Description

Related Issues

Checklist

Breaking Change

scaraux commented May 29, 2020

yamarkz commented May 30, 2020

scaraux commented May 30, 2020 • edited Loading

abhishek199-dhn commented Jun 3, 2020 • edited Loading

scaraux commented Jun 5, 2020

JonasABR commented Jun 19, 2020 • edited Loading

chakrihacker commented Jun 22, 2020

Dahlgren Jul 22, 2020

Choose a reason for hiding this comment

JonasABR Jul 23, 2020

Choose a reason for hiding this comment

douglasiacovelli Nov 9, 2020

Choose a reason for hiding this comment

Dahlgren Nov 9, 2020

Choose a reason for hiding this comment

assemmarwan commented Jul 28, 2020 • edited Loading

JonasABR commented Sep 7, 2020

scaraux commented Sep 10, 2020 • edited Loading

scaraux commented Nov 16, 2020

scaraux commented Feb 17, 2021

stuartmorgan commented Feb 18, 2021

yamarkz commented Feb 18, 2021

yamarkz commented May 21, 2020 •

edited

Loading

scaraux commented May 30, 2020 •

edited

Loading

abhishek199-dhn commented Jun 3, 2020 •

edited

Loading

JonasABR commented Jun 19, 2020 •

edited

Loading

assemmarwan commented Jul 28, 2020 •

edited

Loading

scaraux commented Sep 10, 2020 •

edited

Loading