Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in_platform_interface] Add clientId to the method channel #2935

Conversation

charles-toller
Copy link

@charles-toller charles-toller commented Aug 17, 2020

Description

Add clientId to the platform interface for Android/iOS so the package google_sign_in can be updated with that functionality.

Related Issues

flutter/flutter#57945

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///). (No documentation for internal API)
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@charles-toller
Copy link
Author

@cyanglaz @mehmetf could one of you take a look at this?

@ditman
Copy link
Member

ditman commented Jan 11, 2021

The serverClientId initialization changed with this PR (see the updated example app there): #2116. I'm closing this PR for now, unless it's determined that a more "programmatic" initialization is required.

@ditman ditman closed this Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants