Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[local_auth] Update README for Android Integration #3121

Closed

Conversation

TahaTesser
Copy link
Member

Description

This PR adds the MainActivity code sample in the README for Java & Kotlin required for local_auth, otherwise, an exception will be thrown.

Related Issues

Closes flutter/flutter#41119

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@@ -142,6 +142,40 @@ opposed to Activity. This can be easily done by switching to use
`FlutterFragmentActivity` as opposed to `FlutterActivity` in your
manifest (or your own Activity class if you are extending the base class).

Update your MainActivity.java
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update your MainActivity.java:


OR

Update your MainActivity.kt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update your MainActivity.kt:

ditman added a commit to ditman/flutter-plugins that referenced this pull request Dec 18, 2020
@ditman
Copy link
Member

ditman commented Dec 18, 2020

Updated here: #3348, closing this one.

@ditman ditman closed this Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[local_auth] - Unhandled Exception: PlatformException(no_fragment_activity
3 participants