Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera] Fix video recording exception on Android #3375

Merged
merged 3 commits into from
Dec 27, 2020
Merged

[camera] Fix video recording exception on Android #3375

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a41dd6d
Fixed video recording
BeMacized Dec 27, 2020
b260102
Update changelog and pubspec version
BeMacized Dec 27, 2020
34775c2
Update packages/camera/camera/CHANGELOG.md
BeMacized Dec 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/camera/camera/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.6.3+2

* Fixes stopping video recordings not working on Android before a picture has been taken.
BeMacized marked this conversation as resolved.
Show resolved Hide resolved

## 0.6.3+1

* Fixes flash & torch modes not working on some Android devices.
Expand Down
4 changes: 3 additions & 1 deletion packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,9 @@ public void onCaptureFailed(
@NonNull CameraCaptureSession session,
@NonNull CaptureRequest request,
@NonNull CaptureFailure failure) {
assert (pictureCaptureRequest != null);
if (pictureCaptureRequest == null || pictureCaptureRequest.isFinished()) {
return;
}
String reason;
switch (failure.getReason()) {
case CaptureFailure.REASON_ERROR:
Expand Down
2 changes: 1 addition & 1 deletion packages/camera/camera/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: camera
description: A Flutter plugin for getting information about and controlling the
camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video,
and streaming image buffers to dart.
version: 0.6.3+1
version: 0.6.3+2
homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera

dependencies:
Expand Down