This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Sync the PR template to the new style #3397
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,32 @@ | ||
## Description | ||
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* | ||
|
||
*Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.* | ||
*List which issues are fixed by this PR. You must list at least one issue.* | ||
|
||
## Related Issues | ||
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* | ||
|
||
*Replace this paragraph with a list of issues related to this PR from the [issue database](https://github.com/flutter/flutter/issues). Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.* | ||
|
||
## Checklist | ||
|
||
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. | ||
## Pre-launch Checklist | ||
|
||
- [ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. `[shared_preferences]` | ||
- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. | ||
- [ ] My PR includes unit or integration tests for *all* changed/updated/fixed behaviors (See [Contributor Guide]). | ||
- [ ] All existing and new tests are passing. | ||
- [ ] I updated/added relevant documentation (doc comments with `///`). | ||
- [ ] The analyzer (`flutter analyze`) does not report any problems on my PR. | ||
- [ ] I read and followed the [Flutter Style Guide]. | ||
- [ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences] | ||
- [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. | ||
- [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. | ||
- [ ] I listed at least one issue that this PR fixes in the description above. | ||
- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. | ||
- [ ] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy]. | ||
- [ ] I updated CHANGELOG.md to add a description of the change. | ||
- [ ] I updated/added relevant documentation (doc comments with `///`). | ||
- [ ] I signed the [CLA]. | ||
- [ ] I am willing to follow-up on review comments in a timely manner. | ||
|
||
## Breaking Change | ||
|
||
Does your PR require plugin users to manually update their apps to accommodate your change? | ||
- [ ] All existing and new tests are passing. | ||
|
||
- [ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision). | ||
- [ ] No, this is *not* a breaking change. | ||
If you need help, consider asking for advice on the #hackers-new channel on [Discord]. | ||
|
||
<!-- Links --> | ||
[issue database]: https://github.com/flutter/flutter/issues | ||
[Contributor Guide]: https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md | ||
[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview | ||
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene | ||
[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo | ||
[pub versioning philosophy]: https://www.dartlang.org/tools/pub/versioning | ||
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/master/CONTRIBUTING.md#style | ||
[CLA]: https://cla.developers.google.com/ | ||
[flutter/tests]: https://github.com/flutter/tests | ||
[breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes | ||
[Discord]: https://github.com/flutter/flutter/wiki/Chat | ||
[pub versioning philosophy]: https://www.dartlang.org/tools/pub/versioning | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New link: https://dart.dev/tools/pub/versioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch thanks