Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

move integration test to null safety for multiple plugins. #3646

Merged
merged 9 commits into from
Mar 1, 2021
Merged

move integration test to null safety for multiple plugins. #3646

merged 9 commits into from
Mar 1, 2021

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Feb 26, 2021 •
edited
Loading

Also did some cleanups related to integration tests

@google-cla google-cla bot added the cla: yes label Feb 26, 2021
@cyanglaz cyanglaz removed the request for review from stuartmorgan February 26, 2021 22:37
@cyanglaz cyanglaz marked this pull request as draft February 26, 2021 22:37
@cyanglaz cyanglaz changed the title [connectivity] move integration test to null safety [connectivity]][device_info] move integration test to null safety Feb 26, 2021
@cyanglaz cyanglaz changed the title [connectivity]][device_info] move integration test to null safety move integration test to null safety for multiple plugins. Feb 26, 2021
@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin p: wifi_info_flutter labels Feb 26, 2021
@cyanglaz cyanglaz marked this pull request as ready for review February 27, 2021 00:22
@cyanglaz cyanglaz requested a review from LHLL as a code owner February 27, 2021 00:22
@cyanglaz cyanglaz removed the request for review from LHLL February 27, 2021 01:00
@stuartmorgan stuartmorgan added the nnbd Support for null safety label Mar 1, 2021
stuartmorgan
stuartmorgan approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit c5fd9e5 into flutter:integration_test_nnbd Mar 1, 2021
@cyanglaz cyanglaz deleted the it_connectivity branch March 1, 2021 18:47
stuartmorgan pushed a commit to stuartmorgan/plugins that referenced this pull request May 19, 2021
@stuartmorgan
move integration test to null safety for multiple plugins. (flutter#3646
0e8d746 
)
@stuartmorgan stuartmorgan mentioned this pull request May 19, 2021
Merged
11 tasks
stuartmorgan added a commit that referenced this pull request May 22, 2021
@stuartmorgan
Move integration test to null safety for multiple plugins (#3932)
a864de2 
Cherry-picks #3646 from the NNBD integration test branch, and updates it for changes on master.

Co-authored-by: Chris Yang <[email protected]>
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
Move integration test to null safety for multiple plugins (flutter#3932)
ea44587 
Cherry-picks flutter#3646 from the NNBD integration test branch, and updates it for changes on master.

Co-authored-by: Chris Yang <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees
No one assigned
Labels
cla: yes nnbd Support for null safety p: connectivity p: device_info p: image_picker p: in_app_purchase p: quick_actions p: webview_flutter Edits files for a webview_flutter plugin p: wifi_info_flutter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyanglaz @stuartmorgan