Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Skip pod lint tests #3692

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Skip pod lint tests #3692

merged 2 commits into from
Mar 9, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Mar 9, 2021 •
edited
Loading

Now that the xctest command runs the webview_flutter #3664 and image_picker #3663 unit tests, skip them in the pod lib lint test to avoid doubling the work.

See #3667
Fixes flutter/flutter#77661 (well, avoids it entirely).

@jmagman jmagman self-assigned this Mar 9, 2021
@google-cla google-cla bot added the cla: yes label Mar 9, 2021
ditman
ditman approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ditman
Copy link
Member

ditman commented Mar 9, 2021

This'll have to be merged on red to cure the tree. I can babysit this.

@jmagman
Copy link
Member Author

jmagman commented Mar 9, 2021

\cc @cyanglaz

@ditman
Copy link
Member

ditman commented Mar 9, 2021 

Linting camera.podspec
Running "pod lib lint /private/var/folders/sr/b58hwhtj0jbcf4r09zmg0wlc0000gn/T/cirrus-ci-build/packages/camera/camera/ios/camera.podspec --configuration=Debug --skip-tests --use-libraries"
 -> camera
 -> camera (0.0.1)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Building targets in parallel
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.3.99. (in target 'Pods-App' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.3.99. (in target 'Flutter' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.3.99. (in target 'camera' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.3.99. (in target 'App' from project 'App')
    - NOTE  | [iOS] xcodebuild:  warning: Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the App editor. (in target 'App' from project 'App')
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
camera passed validation.

Looking great so far! Thanks again @jmagman!

@ditman
Copy link
Member

ditman commented Mar 9, 2021

Both lint_darwin_plugins have now passed in the presubmit run.

@jmagman
Copy link
Member Author

jmagman commented Mar 9, 2021

Both lint_darwin_plugins have now passed in the presubmit run.

Safe to land this then to green out the build since that's all it touched. Thanks @ditman!

@jmagman jmagman merged commit d44d155 into flutter:master Mar 9, 2021
@jmagman jmagman deleted the skip-pod-lint-tests branch March 9, 2021 02:05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2021
@engine-flutter-autoroll
d44d155 Skip pod lint tests (flutter/plugins#3692)
e4a44fe
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Mar 9, 2021
@engine-flutter-autoroll
d44d155 Skip pod lint tests (flutter/plugins#3692) (#77671)
23c835a
yasargil added a commit to yasargil/plugins that referenced this pull request Mar 18, 2021
@yasargil
Merge branch 'master' into gmain
f6f7fdd 
* master: (49 commits)
  Prep for alignment with Flutter analysis options (flutter#3703)
  [google_maps_flutter_platform_interface] Mark constructors as const for ids (flutter#3718)
  [image_picker] Endorse image_picker_for_web (flutter#3717)
  Add missing licenses, and add a check (flutter#3720)
  [ci] Add libgcrypt to Docker image. (flutter#3711)
  Reorder the checkboxes in the PR template (flutter#3666)
  Re-endorse connectivity_for_web (flutter#3708)
  Fix missing declaration of windows' default_package (flutter#3705)
  Typos in comments (flutter#2846)
  Skip flutter upgrade for pod linting Cirrus task (flutter#3700)
  [cross_file] Delete. (flutter#3698)
  [tool] Improve check version ci so that it enforces the version in CHANGELOG and pubspec matches. (flutter#3678)
  Streamline CI setup, and reenable macOS credits (flutter#3697)
  [video_player] fixed misleading size and aspect ratio documentation (flutter#3668)
  [image_picker] Implemented 2860 and added Unit Test to test functionality (flutter#3685)
  [shared_preferences] Fix concurrent modification of the shared preferences on Android (flutter#3684)
  [extension_google_sign_in_as_googleapis_auth] Deleted. (flutter#3694)
  Skip pod lint tests (flutter#3692)
  [Video_Player] Remove the deprecated API reference. (flutter#3669)
  [google_sign_in] fix test(flutter#3690)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees

@jmagman jmagman

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[plugins] CI "lint darwin plugins" failing for some plugins, when called with --use-libraries.
2 participants
@jmagman @ditman