Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[all] remove podfile in gitignore and update all podfiles #3747

Merged
merged 3 commits into from
Mar 24, 2021
Merged

[all] remove podfile in gitignore and update all podfiles #3747

merged 3 commits into from
Mar 24, 2021

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Mar 24, 2021 •
edited
Loading

Removes the podfile in gitignore, also add all podfiles.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 24, 2021
@cyanglaz cyanglaz requested review from jmagman and removed request for bparrishMines and gaaclarke March 24, 2021 18:51
jmagman
jmagman approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's all of them, LGTM!

@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 24, 2021
@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 24, 2021
@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 24, 2021
@cyanglaz cyanglaz merged commit 12ea8f2 into flutter:master Mar 24, 2021
@cyanglaz cyanglaz deleted the podfile_not_ignore branch March 24, 2021 22:06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 25, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
@engine-flutter-autoroll
12ea8f2 [all] remove podfile in gitignore and update all podfiles (fl…
847ecbf 
…utter/plugins#3747)
stuartmorgan added a commit to stuartmorgan/plugins that referenced this pull request May 7, 2021
@stuartmorgan
Check in macOS example Podfiles
ad7ca34 
PR flutter#3747 stopped ignoring Podfiles and added the missing iOS Podfiles,
but not the macOS Podfiles.
@stuartmorgan stuartmorgan mentioned this pull request May 7, 2021
Merged
11 tasks
stuartmorgan added a commit that referenced this pull request May 10, 2021
@stuartmorgan
Check in macOS example Podfiles (#3864)
7765fa0 
PR #3747 stopped ignoring Podfiles and added the missing iOS Podfiles,
but not the macOS Podfiles.
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
Check in macOS example Podfiles (flutter#3864)
1d5c634 
PR flutter#3747 stopped ignoring Podfiles and added the missing iOS Podfiles,
but not the macOS Podfiles.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
cla: yes p: battery Edits files for a battery plugin p: camera p: connectivity p: device_info p: google_maps_flutter p: google_sign_in p: integration_test p: ios_platform_images p: local_auth p: package_info p: path_provider p: quick_actions p: sensors p: share p: shared_preferences p: url_launcher p: video_player p: wifi_info_flutter platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyanglaz @fluttergithubbot @jmagman