Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Fix error message when trying to consume purchase on iOS #3752

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

mvanbeusekom
Copy link
Contributor

Redo of #3750, now with correct version number.

Fixes the error message when trying to consume a "consumable product" on iOS. On iOS consuming products manually is not supported and therefore the consumePurchase method on iOS will result in a UnsupportedError. Unfortunately the error message of the error mentioned the "Android" platform:

consume purchase is not available on Android

This PR updates the error message and also extended the unit test to ensure the correct platform is mentioned.

The problem is mentioned as part of issue flutter/flutter#60763 (see this comment)

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@BeMacized BeMacized left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvanbeusekom mvanbeusekom merged commit 708bf9c into flutter:master Mar 25, 2021
@mvanbeusekom mvanbeusekom deleted the iap_consume_purchase_ios branch March 25, 2021 14:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants