Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Replace path_provider_linux widget tests with simple unit tests #3812

Merged
merged 1 commit into from
Apr 19, 2021
Merged

[path_provider] Replace path_provider_linux widget tests with simple unit tests #3812

merged 1 commit into from
Apr 19, 2021

Conversation

stuartmorgan
Copy link
Contributor

These widget tests have been flaky recently, and there's no reason not to just use unit tests instead.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Apr 19, 2021
cyanglaz
cyanglaz approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

blasten
blasten approved these changes Apr 19, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was looking into this issue as well

@stuartmorgan
Copy link
Contributor Author

Landing on red since the removed test is the reason submit-queue is red.

@stuartmorgan stuartmorgan merged commit e52725a into flutter:master Apr 19, 2021
@stuartmorgan stuartmorgan deleted the path-provider-linux-widget-test-removal branch April 19, 2021 17:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2021
@engine-flutter-autoroll
e52725a Replace path_provider_linux widget tests with simple unit tes…
051b367 
…ts (flutter/plugins#3812)
@ditman
Copy link
Member

ditman commented Apr 19, 2021

Thanks for deflaking these!!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 19, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2021
@engine-flutter-autoroll
e52725a Replace path_provider_linux widget tests with simple unit tes…
bff9b72 
…ts (flutter/plugins#3812)
bhaveshptl pushed a commit to bhaveshptl/plugins that referenced this pull request Apr 23, 2021
@bhaveshhzt
Merge branch 'master' into webview_file_picker
72e55e2 
* master: (397 commits)
  [in_app_purchase] Implementation of platform interface (flutter#3781)
  [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819)
  [tools] fix version check command not working for new packages (flutter#3818)
  [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795)
  fix MD (flutter#3815)
  Path provider windows crash fix (flutter#3814)
  [local_auth] docs update (flutter#3103)
  Update PULL_REQUEST_TEMPLATE.md (flutter#3801)
  [quick_actions] handle cold start on iOS correctly (flutter#3811)
  Replace path_provider_linux widget tests with simple unit tests (flutter#3812)
  [sensors] format dart code based on the new dart formatter (flutter#3809)
  [google_sign_in] Fix "pick account" on iOS (flutter#3805)
  [image_picker_platform_interface] Added pickMultiImage (flutter#3782)
  [in_app_purchase] Added currency code and numerical price to product detail model. (flutter#3794)
  [local_auth] Fix iOS crash when no localizedReason (flutter#3780)
  Fix and update version checks (flutter#3792)
  [in_app_purchase] Configured example app to use StoreKit Testing on iOS 14 (flutter#3772)
  [local_auth] Unnecessary reassignment in example removed (flutter#2983)
  [flutter_webview] Fix `allowsInlineMediaPlayback` ignored on iOS (flutter#3791)
  Switch script/tools over to the new analysis options (flutter#3777)
  ...
yasargil added a commit to yasargil/plugins that referenced this pull request Apr 28, 2021
@yasargil
Merge branch 'master' into gmain
58ff4c0 
* master: (79 commits)
  Fix grammatical error in contributing guide (flutter#3217)
  [google_sign_in_web] fix README typos.
  [tool] combine run and runAndExitOnError (flutter#3827)
  [camera] android-rework part 2: Android auto focus feature (flutter#3796)
  [in_app_purchase_platform_interface] Added additional fields to ProductDetails (flutter#3826)
  Move all null safety packages' min dart sdk to 2.12.0 (flutter#3822)
  [path_provider_*] code cleanup: sort directives (flutter#3823)
  [in_app_purchase] Implementation of platform interface (flutter#3781)
  [google_sign_in] Add todo WRT correctly setting X-Goog-AuthUser header (flutter#3819)
  [tools] fix version check command not working for new packages (flutter#3818)
  [camera] android-rework part 1: Base classes to support Android Camera features (flutter#3795)
  fix MD (flutter#3815)
  Path provider windows crash fix (flutter#3814)
  [local_auth] docs update (flutter#3103)
  Update PULL_REQUEST_TEMPLATE.md (flutter#3801)
  [quick_actions] handle cold start on iOS correctly (flutter#3811)
  Replace path_provider_linux widget tests with simple unit tests (flutter#3812)
  [sensors] format dart code based on the new dart formatter (flutter#3809)
  [google_sign_in] Fix "pick account" on iOS (flutter#3805)
  [image_picker_platform_interface] Added pickMultiImage (flutter#3782)
  ...
@stuartmorgan stuartmorgan mentioned this pull request May 27, 2021
Closed
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan @fotiDim
Replace path_provider_linux widget tests with simple unit tests (flut…
06c4231 
…ter#3812)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@blasten blasten blasten approved these changes

Assignees
No one assigned
Labels
cla: yes p: path_provider platform-linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stuartmorgan @ditman @blasten @cyanglaz